Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)

Mike Bishop <notifications@github.com> Mon, 17 August 2020 15:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11B0B3A10DB for <quic-issues@ietfa.amsl.com>; Mon, 17 Aug 2020 08:32:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WyzCrpZK5CBs for <quic-issues@ietfa.amsl.com>; Mon, 17 Aug 2020 08:32:30 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E117E3A0CE7 for <quic-issues@ietf.org>; Mon, 17 Aug 2020 08:32:29 -0700 (PDT)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 0E6F0840F2A for <quic-issues@ietf.org>; Mon, 17 Aug 2020 08:32:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597678349; bh=0ubudc7+EBX+26X50LDPsBodxeev7H4iZbSOahDZ6WQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ft37rH6LMo48GWyuOuNuV7ulIUprycc6l4pxYtJR4VMOMkKCxagc4smg5zHsVh4Bk T6jqTBx4B16wxelySXSz0FvKvpDLaRAvPqRFJdbyamz0pNizgWP8Q0+rbkXPaxnbFB Mxl+jJLP3o1YEKaxT4C/Ud297NkornrLI/wObvrs=
Date: Mon, 17 Aug 2020 08:32:28 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYZQCZ47IPDCFB4OYF5I2CAZEVBNHHCRBYB7A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4005/review/468567203@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4005@github.com>
References: <quicwg/base-drafts/pull/4005@github.com>
Subject: Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3aa30cf3ad7_5d6b19641458d5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jis8VqKoUCp-b99EM1L7_i5Uaqk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Aug 2020 15:32:32 -0000

@MikeBishop commented on this pull request.

Having read this text, I think your comment on the issue is correct -- there are three states here.

> @@ -763,24 +763,33 @@ The RECOMMENDED value is 2 * max_datagram_size.
 
 ## Slow Start
 
-While in slow start, QUIC increases the congestion window by the
-number of bytes acknowledged when each acknowledgment is processed, resulting
-in exponential growth of the congestion window.
+The congestion controller is in slow start any time the congestion window is
+below the slow start threshold.  The congestion controller begins in slow start.

...because the ICW is less than SSThresh, presumably?  Might be worth mentioning that explicitly.

>  
 ## Congestion Avoidance
 
-Slow start exits to congestion avoidance.  Congestion avoidance uses an
-Additive Increase Multiplicative Decrease (AIMD) approach that increases
-the congestion window by one maximum packet size per congestion window
-acknowledged.  When a loss or ECN-CE marking is detected, NewReno halves
-the congestion window, sets the slow start threshold to the new
-congestion window, and then enters the recovery period.
+The congestion controller is in congestion avoidance any time the congestion
+window is at or above the slow start threshold.
+
+Congestion avoidance uses an Additive Increase Multiplicative Decrease (AIMD)
+approach that increases the congestion window by one maximum packet size per
+congestion window acknowledged.
+
+When first entering congestion avoidance, when a packet is declared lost, or
+when the ECN-CE count is detected, the congestion controller halves the

```suggestion
when the ECN-CE count is increased, the congestion controller halves the
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4005#pullrequestreview-468567203