Re: [quicwg/base-drafts] remove unused variable largest_sent_packet (#2449)
ianswett <notifications@github.com> Mon, 11 February 2019 14:25 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B68A1129BBF for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 06:25:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.383
X-Spam-Level:
X-Spam-Status: No, score=-1.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ib_2ijg9oCaq for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 06:25:30 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B6F412008A for <quic-issues@ietf.org>; Mon, 11 Feb 2019 06:25:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=fpVXJ282Me97F3Tc1GKec0DXHN4=; b=aXf768CS4xtgLn5G bDMxdMz+a5C9fP8WAiPjSKTFDZr/eUCkQQg8WlMiEHxQbYHg4JAIwPPKB9CsAuE+ 8HtIVzOlvklrBx2nHVWNLiuzC+ABgIzVXzqIuwoy/v74kmYsaulROKNu4/as7uSI Y+zd5Ys0B8WzrD+pIa7EVoywF+k=
Received: by filter0892p1las1.sendgrid.net with SMTP id filter0892p1las1-32269-5C6185D7-4D 2019-02-11 14:25:28.008037004 +0000 UTC m=+250347.695702263
Received: from github-lowworker-fc273f0.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id eBW9P497TXW9SvZmAi4BHQ for <quic-issues@ietf.org>; Mon, 11 Feb 2019 14:25:27.883 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-fc273f0.cp1-iad.github.net (Postfix) with ESMTP id D5B97C095E for <quic-issues@ietf.org>; Mon, 11 Feb 2019 06:25:27 -0800 (PST)
Date: Mon, 11 Feb 2019 14:25:28 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab912f0b50687636fc7f57595054ff1f1f2e8a4a0992cf00000001187947d792a169ce185b9bbf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2449/c462345431@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2449@github.com>
References: <quicwg/base-drafts/pull/2449@github.com>
Subject: Re: [quicwg/base-drafts] remove unused variable largest_sent_packet (#2449)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6185d7d37da_1bcd3f95748d45c010999d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1eoLVhnFUpW2ZlN96/nVcOwgUj/M44p883fE uupmeFgyu0VsCS5F8WIdiLYOivDacbygaVRftkFLoBH8lJzR3J96gtEOsdYObsBnHD9IStMIFXz/Ns 2bTOobxSg1ZR83Lxyoh6GoB54axxWjkkC90aORHIJQsGotBjq6NRxvHY/TKeAK7uJrIVXdZkKMSVmn g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jpNbqMc3EBfuccx5wnvPNIlzQno>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 14:25:32 -0000
I think it's ok to remove this. It might have been used for early retransmit before, but now that's part of time threshold loss detection. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2449#issuecomment-462345431
- [quicwg/base-drafts] remove unused variable large… Marten Seemann
- Re: [quicwg/base-drafts] remove unused variable l… Martin Thomson
- Re: [quicwg/base-drafts] remove unused variable l… Martin Thomson
- Re: [quicwg/base-drafts] remove unused variable l… ianswett