Date: Wed, 23 Oct 2019 11:22:49 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKYR4QB73RLYEQRF7SF3XXNQTEVBNHHB4UPZEI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3115/545574047@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3115@github.com>
References: <quicwg/base-drafts/issues/3115@github.com>
Subject: Re: [quicwg/base-drafts] Don't use bitmap frames to describe varint
 structures (#3115)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5db09a7937105_1f0e3fc0a70cd9689086";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jvx1FXGpMUhT_x4Aefe1AjIqF_E>


----==_mimepart_5db09a7937105_1f0e3fc0a70cd9689086
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

It's a fair point that when our structures are no longer 32-bit-aligned, the graphics are somewhat misleading.  However, for many of the frames, they're still more useful as a mental model than a C struct style, at least for many readers.  We've adopted conventions to indicate variable-sized fields; if you see places those aren't used properly, please flag them.

We previously had a principle that we don't illustrate frames/objects that contain a single varint.  The "inconsistency" resulted in them being added.  Ultimately, this is a question of editorial style and input on what readers find useful.  Your feedback is welcome and will be considered.

(I'll also note that this seems to oppose the discussion about moving the transport params from TLS-style description language to wire-frames.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3115#issuecomment-545574047
----==_mimepart_5db09a7937105_1f0e3fc0a70cd9689086
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>It's a fair point that when our structures are no longer 32-bit-aligned, the graphics are somewhat misleading.  However, for many of the frames, they're still more useful as a mental model than a C struct style, at least for many readers.  We've adopted conventions to indicate variable-sized fields; if you see places those aren't used properly, please flag them.</p>
<p>We previously had a principle that we don't illustrate frames/objects that contain a single varint.  The "inconsistency" resulted in them being added.  Ultimately, this is a question of editorial style and input on what readers find useful.  Your feedback is welcome and will be considered.</p>
<p>(I'll also note that this seems to oppose the discussion about moving the transport params from TLS-style description language to wire-frames.)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/issues/3115?email_source=notifications&amp;email_token=AFTOJKZW2FVDYXKR2UZLTA3QQCI7TA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCMZHY#issuecomment-545574047">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK4EBMU2JQWCSGRLR4DQQCI7TANCNFSM4JB6VQ2Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK6I6AUA56PPXRY7DR3QQCI7TA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCMZHY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/3115?email_source=notifications\u0026email_token=AFTOJKZW2FVDYXKR2UZLTA3QQCI7TA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCMZHY#issuecomment-545574047",
"url": "https://github.com/quicwg/base-drafts/issues/3115?email_source=notifications\u0026email_token=AFTOJKZW2FVDYXKR2UZLTA3QQCI7TA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCMZHY#issuecomment-545574047",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5db09a7937105_1f0e3fc0a70cd9689086--