Re: [quicwg/base-drafts] Exception for Retire Prior To (#3643)

Martin Thomson <notifications@github.com> Thu, 14 May 2020 01:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C40D53A08EA for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 18:07:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.272
X-Spam-Level:
X-Spam-Status: No, score=-3.272 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sjnobdB49vQO for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 18:07:25 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B83663A090E for <quic-issues@ietf.org>; Wed, 13 May 2020 18:07:22 -0700 (PDT)
Received: from github-lowworker-1dbcc59.ash1-iad.github.net (github-lowworker-1dbcc59.ash1-iad.github.net [10.56.105.54]) by smtp.github.com (Postfix) with ESMTP id AD6B9A0E31 for <quic-issues@ietf.org>; Wed, 13 May 2020 18:07:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589418441; bh=pFcmxs7LSzdgppUjKuWwnbiT8BAjEGWcjes+qX0iCHs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vk6RkjlHS3gRb9XEc74MMKt+5ZpMGzctHUOvp6ugBT4Nu90lcSErNp/1e8vLT7DE2 sOXR3k5bydn5bijm+JatTMuW2oxb+w4Tedh9pxetYsqkd3KrBZ9Lxufd5vV/KhN3j6 79ZSjtkPqBG2hsaEKn14bMAcG33Ky5/F9jk26JLY=
Date: Wed, 13 May 2020 18:07:21 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK54NQHUDHANMEDHAXV4ZB5MTEVBNHHCJO45K4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3643/review/411398917@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3643@github.com>
References: <quicwg/base-drafts/pull/3643@github.com>
Subject: Re: [quicwg/base-drafts] Exception for Retire Prior To (#3643)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebc99c99d840_7fba3fd8768cd9601073ab"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/k1pl-OwqQ7ZCyK-qU5K1IRw9uuE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2020 01:07:27 -0000

@martinthomson commented on this pull request.



> +will stay within the limit.  An endpoint that receives a NEW_CONNECTION_ID
+frame that increases the number of active connection IDs - without a Retire
+Prior To field that requests retirement of enough active connections to keep the
+total number of active connection IDs within the value the endpoint advertised
+in its active_connection_id_limit transport parameter - MUST close the
 connection with an error of type CONNECTION_ID_LIMIT_ERROR.

Maybe this is better:

```suggestion
will stay within the limit.  A NEW_CONNECTION_ID frame might cause an endpoint
might add some active connection IDs and retire others based on the value of the
Retire Prior To field.  After processing a NEW_CONNECTION_ID frame and adding a
retiring active connection IDs, if the number of active connections exceeds the
value advertised in its active_connection_id_limit transport parameter, an
endpoint MUST close the connection with an error of type
CONNECTION_ID_LIMIT_ERROR.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3643#pullrequestreview-411398917