Re: [quicwg/base-drafts] Scope of disable_active_migration (#3670)

Kazuho Oku <notifications@github.com> Tue, 19 May 2020 23:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 708853A040B for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 16:39:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id npZJ9ZVXi9nf for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 16:39:22 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01E283A0407 for <quic-issues@ietf.org>; Tue, 19 May 2020 16:39:21 -0700 (PDT)
Received: from github-lowworker-b19c547.va3-iad.github.net (github-lowworker-b19c547.va3-iad.github.net [10.48.17.66]) by smtp.github.com (Postfix) with ESMTP id 3DD546E06C8 for <quic-issues@ietf.org>; Tue, 19 May 2020 16:39:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589931561; bh=ojZV6KhpJ0D+Qf9WSOw/nUzk0g9NVG1bpjmziJBG17E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KoTueKi70pcPaUSqjGkt967gYNyf9DAkjshfFLmxQ7OIpNPuxmsb9eAhI/q2StRxa r13jYRg5bUqh6Z35rkgS8Kko3LejQ2auo6bCHQye9p/h9k63AzlG80FsRTnl7qDp2s ztbuxrXY4P3e4dkLy5LjSdEG8sEd/qJ2au9vZlb0=
Date: Tue, 19 May 2020 16:39:21 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK47NPNE2O77AUCMCFN42BHSTEVBNHHCKCGAH4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3670/review/414895639@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3670@github.com>
References: <quicwg/base-drafts/pull/3670@github.com>
Subject: Re: [quicwg/base-drafts] Scope of disable_active_migration (#3670)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec46e292e133_5c843fb5ad4cd9641324b3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/k3doPUePQjMewU4o-Ghyb9psJOs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 23:39:24 -0000

@kazuho commented on this pull request.

LGTM modulo the point below.

> @@ -4872,11 +4874,11 @@ max_ack_delay (0x0b):
 disable_active_migration (0x0c):
 
 : The disable active migration transport parameter is included if the endpoint
-  does not support active connection migration ({{migration}}). Peers of an
-  endpoint that sets this transport parameter MUST NOT send any packets,
-  including probing packets ({{probing}}), from a local address or port other
-  than that used to perform the handshake.  This parameter is a zero-length
-  value.
+  does not support active connection migration ({{migration}}) on the address
+  being used during the handshake.  Peers of an endpoint that sets this
+  transport parameter MUST NOT send any packets, including probing packets
+  ({{probing}}), from a local address or port other than that used to perform
+  the handshake. This parameter is a zero-length value.

To me it seems that we need to also change this sentence (starting from "Peers ..."). We need to tighten the restriction to only when the client sends the packets to the original address of the server.

Maybe something like: _Peers of an endpoint that sets this transport parameter MUST NOT send any packets, including probing packets ({{probing}}) __to the address that was used to perform the handshake__, from a local address or port other than that used to perform the handshake._

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3670#pullrequestreview-414895639