Re: [quicwg/base-drafts] GOAWAY means no more (#3338)

Kazuho Oku <notifications@github.com> Tue, 14 January 2020 13:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E8221200CE for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 05:30:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rZmN6tX18_Ht for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 05:30:12 -0800 (PST)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1500D1200D5 for <quic-issues@ietf.org>; Tue, 14 Jan 2020 05:30:12 -0800 (PST)
Date: Tue, 14 Jan 2020 05:30:11 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579008611; bh=tNo33kw+f3rJlwolNxlm+vxE1iMOmvtUFh4WjtEzWd0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WCWJV/JH9k0Rs7JC8bKD+M3OSoYhqL9+f5igaPXzWghSrFkWRygAqlZ/+efPJUe+x 08lGHgHZG/wZy0ZeqdQ5ZSGWj5CQwR/IC2cqv6Su0w1xVruIWvv1gAox9Y3BZU8v79 GhvVcZzXgnyl3otUb1cDmaHtAVYGyeIeG9Z4vuwM=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2AHN62QECPOBHUFLV4FL2OHEVBNHHCBPAYFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3338/review/342528843@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3338@github.com>
References: <quicwg/base-drafts/pull/3338@github.com>
Subject: Re: [quicwg/base-drafts] GOAWAY means no more (#3338)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1dc2633e3dd_43453facf8ccd960949a9"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/k73o_12AJ1X2DgPeMzHG8_IZbM8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2020 13:30:18 -0000

kazuho commented on this pull request.



> @@ -696,18 +696,19 @@ requests or pushes were accepted prior to the connection shutdown.  Endpoints
 SHOULD abruptly terminate any requests or pushes that have identifiers greater
 than or equal to the smallest identifier sent in a GOAWAY frame.
 
-Endpoints MUST NOT initiate new requests or pushes on the connection with an
-identifier greater than or equal to the smallest identifier received in a GOAWAY
-frame.  Clients MAY establish a new connection to send additional requests.
+Endpoints MUST NOT initiate new requests or promise new pushes on the connection
+after receipt of a GOAWAY from the peer.  Clients MAY establish a new connection

Maybe change GOAWAY to "GOAWAY frame"? I think we consistently use the latter.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3338#pullrequestreview-342528843