Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
ianswett <notifications@github.com> Thu, 20 December 2018 02:29 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 94C8B130DE8 for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 18:29:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.447
X-Spam-Level:
X-Spam-Status: No, score=-6.447 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QjVjf5xr3gaQ for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 18:29:07 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D904F130DD5 for <quic-issues@ietf.org>; Wed, 19 Dec 2018 18:29:06 -0800 (PST)
Date: Wed, 19 Dec 2018 18:29:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545272946; bh=1q3HpyZiYK9qfvtTW0YccAYRqNi2HxLttmT1whJAuU4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bAQYClUls1aho2Z50ViGEvpB2ks08GoveakwixZQ1+xUsppOTH5unSLsOEMVjaCwQ o12kqsvQ0DzfsufpmSTcvh28wq9mY4zpWwPDQPALdc5FgWvUD2mULFyJqJtG/9V4nB 1Bm6NXjWis8wWmmO9ACZGDJEUQsYOU6b/BYZjwNA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab034dee5d634040e14e2e2d9d4be480581eaa6f2092cf000000011832c07192a169ce176a63e1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2212/review/186828709@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2212@github.com>
References: <quicwg/base-drafts/pull/2212@github.com>
Subject: Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1afe72284f_18433fee9d2d45bc5070b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kFKTSK4pl7Nzf4qcE55en26BvlM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 02:29:09 -0000
ianswett commented on this pull request. I think I'd prefer swapping the preference order I wrote, and say you SHOULD declare all packets lost, and if not, you MUST send an ack-eliciting packet to determine whether any packets were really lost? I think we need a better example. Too bad MESSAGE/DATAGRAM is just a draft. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-186828709
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- [quicwg/base-drafts] Proposed change to #1965 (#2… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Nick Banks
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Kazuho Oku
- Re: [quicwg/base-drafts] Proposed change to #1965… MikkelFJ
- Re: [quicwg/base-drafts] Proposed change to #1965… MikkelFJ
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Martin Thomson