Date: Wed, 19 Dec 2018 18:29:06 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab034dee5d634040e14e2e2d9d4be480581eaa6f2092cf000000011832c07192a169ce176a63e1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2212/review/186828709@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2212@github.com>
References: <quicwg/base-drafts/pull/2212@github.com>
Subject: Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c1afe72284f_18433fee9d2d45bc5070b6";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kFKTSK4pl7Nzf4qcE55en26BvlM>


----==_mimepart_5c1afe72284f_18433fee9d2d45bc5070b6
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.

I think I'd prefer swapping the preference order I wrote, and say you SHOULD declare all packets lost, and if not, you MUST send an ack-eliciting packet to determine whether any packets were really lost?

I think we need a better example.  Too bad MESSAGE/DATAGRAM is just a draft.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-186828709
----==_mimepart_5c1afe72284f_18433fee9d2d45bc5070b6
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<p>I think I'd prefer swapping the preference order I wrote, and say you SHOULD declare all packets lost, and if not, you MUST send an ack-eliciting packet to determine whether any packets were really lost?</p>
<p>I think we need a better example.  Too bad MESSAGE/DATAGRAM is just a draft.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-186828709">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq4xpSv0x4RXM7WH_wFRENuSOjjYiks5u6vXygaJpZM4ZbU7m">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkqxpg8HHcswqJ-A7ecGz57XRtECOxks5u6vXygaJpZM4ZbU7m.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #2212"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-186828709"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-186828709",
"url": "https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-186828709",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c1afe72284f_18433fee9d2d45bc5070b6--