Re: [quicwg/base-drafts] Forbid zero-length connection ID with preferred addresses (#3565)

David Schinazi <notifications@github.com> Thu, 09 April 2020 00:16 UTC

Date: Wed, 08 Apr 2020 17:16:22 -0700
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYDLBYOMMXKHU5QBUV4TJFFNEVBNHHCHAGI2A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3565/review/390414323@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3565@github.com>
References: <quicwg/base-drafts/pull/3565@github.com>
Subject: Re: [quicwg/base-drafts] Forbid zero-length connection ID with preferred addresses (#3565)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e8e69569a168_7cad3fe4168cd964105576"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kJP4OnbuKvLFDs-ehZFD6DUvPiY>

@DavidSchinazi commented on this pull request.



> @@ -4740,6 +4740,14 @@ preferred_address (0x0d):
   be at least one unused active connection ID when the client initiates
   migration to the preferred address.
 
+: The Connection ID and Stateless Reset Token fields of a preferred address are
+  identical in syntax and semantics to the corresponding fields of a
+  NEW_CONNECTION_ID frame ({{frame-new-connection-id}}).  A server that chooses
+  a zero-length connection ID MUST NOT provide a preferred address.  Similarly,

I don't think this is right. NEW_CONNECTION_ID frames don't ban zero-length CIDs. What NEW_CONNECTION_ID bans is switching between zero-length CIDs and non-zero-length CIDs. If the server is using a zero-length CID, it should be allowed to switch to a preferred address, and also use zero-length CIDs there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3565#pullrequestreview-390414323

[quicwg/base-drafts] Forbid zero-length connectio… Martin Thomson
Re: [quicwg/base-drafts] Forbid zero-length conne… Mike Bishop
Re: [quicwg/base-drafts] Forbid zero-length conne… ianswett
Re: [quicwg/base-drafts] Forbid zero-length conne… Kazuho Oku
Re: [quicwg/base-drafts] Forbid zero-length conne… Marten Seemann
Re: [quicwg/base-drafts] Forbid zero-length conne… David Schinazi
Re: [quicwg/base-drafts] Forbid zero-length conne… Martin Thomson
Re: [quicwg/base-drafts] Forbid zero-length conne… Martin Thomson