IETF Logo Mail Archive

Re: [quicwg/base-drafts] Forbid zero-length connection ID with preferred addresses (#3565)

David Schinazi <notifications@github.com> Thu, 09 April 2020 00:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C73EF3A1A69 for <quic-issues@ietfa.amsl.com>; Wed, 8 Apr 2020 17:16:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.648
X-Spam-Level:
X-Spam-Status: No, score=-1.648 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q5Gef1ssyvFR for <quic-issues@ietfa.amsl.com>; Wed, 8 Apr 2020 17:16:23 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6221D3A1A68 for <quic-issues@ietf.org>; Wed, 8 Apr 2020 17:16:23 -0700 (PDT)
Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id A92AC6E0CA1 for <quic-issues@ietf.org>; Wed, 8 Apr 2020 17:16:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586391382; bh=YFtUklqEtg16x1YrpKIRXbB4FurNo5d5Ee6zvoJmiMM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zhbU8Gd6/yrlkBAh+exNflQmoonmipov+DjFPISgd+WL/HsBPT834xwTgAdFHUci8 27XM5FLLDTskIUAauJ4kpsl1tf0LUP35bb0NyW4a9xf3e+05OFvoxkq/y9UCUkiczd Wbj6ptU+oKvHYOwb2zUPnG9pkF19TktfA3y2w6c0=
Date: Wed, 08 Apr 2020 17:16:22 -0700
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYDLBYOMMXKHU5QBUV4TJFFNEVBNHHCHAGI2A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3565/review/390414323@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3565@github.com>
References: <quicwg/base-drafts/pull/3565@github.com>
Subject: Re: [quicwg/base-drafts] Forbid zero-length connection ID with preferred addresses (#3565)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e8e69569a168_7cad3fe4168cd964105576"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kJP4OnbuKvLFDs-ehZFD6DUvPiY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Apr 2020 00:16:25 -0000

@DavidSchinazi commented on this pull request.



> @@ -4740,6 +4740,14 @@ preferred_address (0x0d):
   be at least one unused active connection ID when the client initiates
   migration to the preferred address.
 
+: The Connection ID and Stateless Reset Token fields of a preferred address are
+  identical in syntax and semantics to the corresponding fields of a
+  NEW_CONNECTION_ID frame ({{frame-new-connection-id}}).  A server that chooses
+  a zero-length connection ID MUST NOT provide a preferred address.  Similarly,

I don't think this is right. NEW_CONNECTION_ID frames don't ban zero-length CIDs. What NEW_CONNECTION_ID bans is switching between zero-length CIDs and non-zero-length CIDs. If the server is using a zero-length CID, it should be allowed to switch to a preferred address, and also use zero-length CIDs there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3565#pullrequestreview-390414323

v2.8.10 | Report a Bug | By Email