Re: [quicwg/base-drafts] No reading of 1-RTT before the handshake is complete (#3224)

Jana Iyengar <notifications@github.com> Tue, 19 November 2019 02:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 71FC0120274 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 18:38:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p9vxSTmVIm5I for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 18:38:40 -0800 (PST)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B1AB120232 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 18:38:40 -0800 (PST)
Date: Mon, 18 Nov 2019 18:38:39 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574131119; bh=IODrjzEZywQvOBBDkaODbM1ZsNOw9nDKarfEo9mJxdw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XEg+4JGDg2SS+1XBu+X2Lg3MR+YKOGRZlW5XKcyXFGb/uosLWHZ0NBhvkppvRTJR5 frN9DDDkLDn9FIeR4QeRir0Mrz4w+tbFmKf44knuLuTYU4VQGIf+gRUKVNScJ1vZ+H BCGgImhZoQIXuil+dRG4rnQh6lDGq7bOpRUEEShk=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4KGULW5EBAQIQJOJV34CEC7EVBNHHB6ES7L4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3224/review/318753700@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3224@github.com>
References: <quicwg/base-drafts/pull/3224@github.com>
Subject: Re: [quicwg/base-drafts] No reading of 1-RTT before the handshake is complete (#3224)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd355af2acb7_3ecb3feeca8cd9641191c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kLE3whUPhlV_6CuP4UZ1P_uuZ9Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 02:38:43 -0000

janaiyengar commented on this pull request.



> @@ -1171,27 +1171,34 @@ Note:
 ## Receiving Out-of-Order Protected Frames {#pre-hs-protected}
 
 Due to reordering and loss, protected packets might be received by an endpoint
-before the final TLS handshake messages are received.  A client will be unable
-to decrypt 1-RTT packets from the server, whereas a server will be able to
-decrypt 1-RTT packets from the client.
+before the final TLS handshake messages are received.  Each endpoint MUST NOT
+decrypt 1-RTT packets from its peer prior to completing the handshake.

I'd leave the old text in for emphasis, and also a minor edit: "A client will be unable to decrypt 1-RTT packets from the server, whereas a server will be able to decrypt 1-RTT packets from the client. Both endpoints MUST NOT decrypt 1-RTT  packets from their peers prior to completing the handshake."


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3224#pullrequestreview-318753700