IETF Logo Mail Archive

Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)

janaiyengar <notifications@github.com> Mon, 16 October 2017 22:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 307DC13457F for <quic-issues@ietfa.amsl.com>; Mon, 16 Oct 2017 15:08:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.615
X-Spam-Level:
X-Spam-Status: No, score=-5.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cWcHC129D4xC for <quic-issues@ietfa.amsl.com>; Mon, 16 Oct 2017 15:08:21 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext8.iad.github.net [192.30.252.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 38B4B1331E7 for <quic-issues@ietf.org>; Mon, 16 Oct 2017 15:08:19 -0700 (PDT)
Date: Mon, 16 Oct 2017 15:08:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1508191698; bh=JKMdGGpE1PebWAcPLLxf3xMjTMtblfozxL7o8vds5E0=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zZ/7wXKeE3h1XPfEelCS9UpRkkfPmKSOp0sYJJSEDYemxr/6ncGPPIbGdMoWJMC38 +Q0Ooa5TX44HWIBYDjtFPvUSh2N0qO2abMYfsUEtPYZCObWQbryhZmSKbGIMXjNTVh yQZDEUpMZ65tynFwo8Z10/R4Ly3olcPH1rIxvmK0=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2d776bc267c1d80c59465c41ab3aa39794ff17d992cf0000000115fcefd292a169ce0fd14a5e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/872/c337058116@github.com>
In-Reply-To: <quicwg/base-drafts/pull/872@github.com>
References: <quicwg/base-drafts/pull/872@github.com>
Subject: Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59e52dd298ce7_1653f8329532f28778a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kM7-7uQJRrzt4X9UlOXSBRvBrdM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 22:08:22 -0000

@martinthomson On using the high-order bits instead of the low-order ones, I don't have a strong opinion, but it's not complicated to use low-order ones. We've done that for client/server streams, this merely extends it.

I'm happy with the PR (modulo adding default MAX_STREAM_ID and MAX_STREAM_DATA separately for uni and bi streams), and I think we can make further changes after we get this one in.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/872#issuecomment-337058116

v2.46.0 | Report a Bug | By Email | System Status