Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E67C8130DF9 for ; Mon, 26 Nov 2018 19:18:12 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -9.46 X-Spam-Level: X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lQImmyzkAAbn for ; Mon, 26 Nov 2018 19:18:11 -0800 (PST) Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3A47127B4C for ; Mon, 26 Nov 2018 19:18:10 -0800 (PST) Date: Mon, 26 Nov 2018 19:18:09 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543288689; bh=TAu2EcUGxjQBb4NXLkMoa/9jgVc8pbJMNpYy9rVW2bI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zcdySsJ9SGl8084Tv/I2TT/jVc4b1mmyXQ9BcItBv0PCHFhA15hKME+ZSshLtIiTb 6CQTmHGd0FKdtU5gDOXVk3W//hYVuSttCFFsg5PMC14KNjPYOcDoATb4OFYsVJwO0W 1xfDMi9/mAwkUXfys0pcBzED/l6lGIE6eQ4f4qHA= From: janaiyengar Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] TLS provides AEAD and KDF (#2046) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5bfcb771af27f_223b3f844bed45b81222e8"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: janaiyengar X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 03:18:13 -0000 ----==_mimepart_5bfcb771af27f_223b3f844bed45b81222e8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit janaiyengar approved this pull request. > @@ -710,14 +722,19 @@ based on the client's initial Destination Connection ID, as described in {{initial-secrets}}. The keys used for packet protection are computed from the TLS secrets using the -method described in Section 7.3 of {{!TLS13}}), with the labels "quic key" and -"quic iv" in place of the labels used by TLS (that is, "key" and "iv" -respectively). Using these labels provides key separation between QUIC and TLS, -see {{key-diversity}}. +KDF provided by TLS. In TLS 1.3, the HKDF-Expand-Label function described in +Section 7.1 of {{!TLS13}}) is used, using the hash function from the negotiated +cipher suite. Other versions of TLS MUST provide a similar function in order to +be used QUIC. + + The current encryption level secret and the label "quic key" are input to the ```suggestion The current encryption level secret and the label "quic key" are input to the ``` > @@ -753,9 +770,8 @@ thus ensuring that the keys are different for each version of QUIC. This prevents a middlebox that only recognizes one version of QUIC from seeing or modifying the contents of handshake packets from future versions. -The HKDF function defined in TLS 1.3 MUST be used even in case the minimum TLS -version that the endpoint is willing to use is greater, so as to assure that -the peer can decrypt the packet. +The HKDF-Expand-Label function defined in TLS 1.3 MUST be used for Initial Might be worth stating "For QUICv1 ..." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2046#pullrequestreview-178595698 ----==_mimepart_5bfcb771af27f_223b3f844bed45b81222e8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@janaiyengar approved this pull request.

In draft-ietf-quic-tls.md:

> @@ -710,14 +722,19 @@ based on the client&=
#39;s initial Destination Connection ID, as described in
 {{initial-secrets}}.
 =

 The keys used for packet protection are computed from the TLS secrets us=
ing the
-method described in Section 7.3 of {{!TLS13}}), with the labels "qu=
ic key" and
-"quic iv" in place of the labels used by TLS (that is, "k=
ey" and "iv"
-respectively).  Using these labels provides key separation between QUIC =
and TLS,
-see {{key-diversity}}.
+KDF provided by TLS.  In TLS 1.3, the HKDF-Expand-Label function describ=
ed in
+Section 7.1 of {{!TLS13}}) is used, using the hash function from the neg=
otiated
+cipher suite.  Other versions of TLS MUST provide a similar function in =
order to
+be used QUIC.
+
+ The current encryption level secret and the label "quic key" =
are input to the
=E2=AC=87=EF=B8=8F Suggested change 
- The current encryption level secret and the =
label "quic key" are input to the
+The current encryption level secret and the label "quic key" are input t=
o the

In draft-ietf-quic-tls.md:

> @@ -753,9 +770,8 @@ thus ensuring that the=
 keys are different for each version of QUIC. This
 prevents a middlebox that only recognizes one version of QUIC from seein=
g or
 modifying the contents of handshake packets from future versions.
 =

-The HKDF function defined in TLS 1.3 MUST be used even in case the minim=
um TLS
-version that the endpoint is willing to use is greater, so as to assure =
that
-the peer can decrypt the packet.
+The HKDF-Expand-Label function defined in TLS 1.3 MUST be used for Initi=
al

Might be worth stating "For QUICv1 ..."

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or mute the thread.

= = ----==_mimepart_5bfcb771af27f_223b3f844bed45b81222e8--