Re: [quicwg/base-drafts] Modify QPACK steam and instruction terminology (#2440)

Lucas Pardue <notifications@github.com> Tue, 12 February 2019 00:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7DF571276D0 for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 16:47:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AQttGvJ_KL7F for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 16:47:18 -0800 (PST)
Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE67E124B0C for <quic-issues@ietf.org>; Mon, 11 Feb 2019 16:47:18 -0800 (PST)
Date: Mon, 11 Feb 2019 16:47:18 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549932438; bh=S7SotFYZXr88gZRGi6XSk7xq3Z9P7gsUvW7a8evhjeE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SAcCfHGeC2q6lYqSbmN4yL6u2Dkl37AwoWqs9kNZewPas1fnJL4QPnjitbxhApXsX r8IDkD2UguVRk8zs/VCSHpg1nJxt/rZok79CnM9T/EhyQChDCYlFWhDUsvCeQ/LXJa FjlydMudM4TGnhPG76xXJqiVVxSjkiTQcQC9AKVM=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf4aacfbcc3b3b5df993dc710a66766a4b5559fcd92cf000000011879d99692a169ce18557f5e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2440/review/202422733@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2440@github.com>
References: <quicwg/base-drafts/pull/2440@github.com>
Subject: Re: [quicwg/base-drafts] Modify QPACK steam and instruction terminology (#2440)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6217965e70_66283fb89fad45c06531fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kVnrHZzsBrZ3v6huIxnzXrcl-AY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2019 00:47:20 -0000

LPardue commented on this pull request.



>  
-QPACK instructions occur in three locations, each of which uses a separate
-instruction space:
+There are three separate QPACK instruction spaces. Encoder instructions
+({{encoder-instructions}}) carry table updates, decoder instructions
+({{decoder-instructions}}) carry acknowledgments of table modifications and
+header processing, and header block instructions ({{header-block-instructions}})
+compress a header list by referring to the QPACK table state.

Well, an encoder view of the header block is not to reconstruct the list. 

The initial text simply stated that these instructions refer to tables. Adding flavour seems to complicate the matter, unless we think spelling out verbatim is useful. 

Would something like "header block instructions convey an encoded representation of a header list by referring to the QPACK table state" suffice?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2440#discussion_r255758199