Re: [quicwg/base-drafts] New paths may seed initial_rtt (#2687)

Jana Iyengar <notifications@github.com> Thu, 23 May 2019 10:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01EFF1200E6 for <quic-issues@ietfa.amsl.com>; Thu, 23 May 2019 03:56:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.606
X-Spam-Level:
X-Spam-Status: No, score=-6.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5odxxYNpWZT0 for <quic-issues@ietfa.amsl.com>; Thu, 23 May 2019 03:56:27 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40461120019 for <quic-issues@ietf.org>; Thu, 23 May 2019 03:56:27 -0700 (PDT)
Date: Thu, 23 May 2019 03:56:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1558608986; bh=tn8e/Dctz5oPOhglGdRo3M2tH9HvSJ6xnLxrEpTFyM0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jeIDzhavQLlIXo9JViZ0uvwHFBSty6eJgdKA7h+d5auu+rf6LX7nZT05s80wYYJwy Uoggla4S2gScDo22sH8PpMQdz8rji6XAWWpNIcQbl8GfANje5pTOJGMqUDFpym+bNl RKdcFSMxSqrgzTSafdd5WyjwEwwYKSusrgDU8Cwg=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5AONZGBACGBVMG5RF26OXNVEVBNHHBUYRXKM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2687/review/241128629@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2687@github.com>
References: <quicwg/base-drafts/pull/2687@github.com>
Subject: Re: [quicwg/base-drafts] New paths may seed initial_rtt (#2687)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ce67c5a47143_397c3ff52bccd96c59989d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/k_pw82kyFBeTfQlOkXbaM1ihG-U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 May 2019 10:56:29 -0000

janaiyengar commented on this pull request.



> @@ -521,6 +521,10 @@ is available, or if the network changes, the initial RTT SHOULD be set to 500ms,
 resulting in a 1 second initial handshake timeout as recommended in
 {{?RFC6298}}.
 
+A connection MAY use the delay between sending a PATH_CHALLENGE and receiving
+a PATH_RESPONSE to seed initial_rtt for a new path, but the delay MUST not be

```suggestion
a PATH_RESPONSE to seed initial_rtt for a new path, but the delay MUST NOT be
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2687#pullrequestreview-241128629