Date: Wed, 16 Oct 2019 09:41:58 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZOZAQIY3A5JQ5SO4N3WSEONEVBNHHB4RTQYY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3098/review/302718749@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3098@github.com>
References: <quicwg/base-drafts/pull/3098@github.com>
Subject: Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5da748562b2b0_17fa3ff8b7ecd96c598c2";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kehyhUDxbo7wcoegk7_CtvOSq2s>


----==_mimepart_5da748562b2b0_17fa3ff8b7ecd96c598c2
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

marten-seemann commented on this pull request.



> @@ -167,8 +168,8 @@ of frames contained in a packet affect recovery and congestion control logic:
   performance of the QUIC handshake and use shorter timers for
   acknowledgement.
 
-* Packets that contain only ACK frames do not count toward congestion control
-  limits and are not considered in-flight.
+* Packets that contain only ACK or CONNECTION_CLOSE frames do not count toward

It's not clear if the "only" applies only to ACKs or to both.

> @@ -192,8 +192,9 @@ QUIC packet:
 
 Ack-eliciting Packet:
 
-: A QUIC packet that contains frames other than ACK and PADDING. These cause a
-  recipient to send an acknowledgment (see {{sending-acknowledgements}}).
+: A QUIC packet that contains frames other than ACK, PADDING, and
+  CONNECTION_CLOSE. These cause a recipient to send an acknowledgment (see

If you bundle a CONNECTION_CLOSE with other frames, it's still not ack ack-eliciting, is it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3098#pullrequestreview-302718749
----==_mimepart_5da748562b2b0_17fa3ff8b7ecd96c598c2
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@marten-seemann</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3098#discussion_r335586385">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -167,8 +168,8 @@ of frames contained in a packet affect recovery and congestion control logic:
   performance of the QUIC handshake and use shorter timers for
   acknowledgement.
 
-* Packets that contain only ACK frames do not count toward congestion control
-  limits and are not considered in-flight.
+* Packets that contain only ACK or CONNECTION_CLOSE frames do not count toward
</pre>
<p>It's not clear if the "only" applies only to ACKs or to both.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3098#discussion_r335586769">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -192,8 +192,9 @@ QUIC packet:
 
 Ack-eliciting Packet:
 
-: A QUIC packet that contains frames other than ACK and PADDING. These cause a
-  recipient to send an acknowledgment (see {{sending-acknowledgements}}).
+: A QUIC packet that contains frames other than ACK, PADDING, and
+  CONNECTION_CLOSE. These cause a recipient to send an acknowledgment (see
</pre>
<p>If you bundle a CONNECTION_CLOSE with other frames, it's still not ack ack-eliciting, is it?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3098?email_source=notifications&amp;email_token=AFTOJK52XPPKU54PCCH6R4TQO475NA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFR6HI#pullrequestreview-302718749">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK3NVCI27KQMVVIAEVTQO475NANCNFSM4JBNK72Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK77Z4ZFBL65EB6LHGLQO475NA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFR6HI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3098?email_source=notifications\u0026email_token=AFTOJK52XPPKU54PCCH6R4TQO475NA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFR6HI#pullrequestreview-302718749",
"url": "https://github.com/quicwg/base-drafts/pull/3098?email_source=notifications\u0026email_token=AFTOJK52XPPKU54PCCH6R4TQO475NA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFR6HI#pullrequestreview-302718749",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5da748562b2b0_17fa3ff8b7ecd96c598c2--