Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167)

Jana Iyengar <notifications@github.com> Tue, 29 October 2019 23:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 685C91200A3 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:25:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xdVnKRra6wXB for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:25:05 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C69F12006D for <quic-issues@ietf.org>; Tue, 29 Oct 2019 16:25:05 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id A9892A039C for <quic-issues@ietf.org>; Tue, 29 Oct 2019 16:25:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572391504; bh=l2PPPxE4i3xNaBk4S/df3h5uTmcxbJ/xEeICcWvWfdQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YsLcMrCVtAVn2RfssqLa8G+EunfuzaRvjz+3rtJbr3g8hl1yLPnKj2Tc0CxTE9ktX Rk0TWGSB4kOqDpXSHn4y+Bgztb8z2LKCMeBZIIOJ2rCQ85s5B/pUErmTgf58ggqlYY BJojcxU6g3cpSAzDfLhRKdHoaKOwuic/dnzm2cmE=
Date: Tue, 29 Oct 2019 16:25:04 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4UUL45VIM5ECGX2DF3YYFOBEVBNHHB5JW7PY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3167/review/308887171@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3167@github.com>
References: <quicwg/base-drafts/pull/3167@github.com>
Subject: Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8ca509a58a_769a3fc319ccd9601573ea"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ker53Ml99fU49GRNGAE5qhcKPyE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 23:25:08 -0000

janaiyengar requested changes on this pull request.



> @@ -1258,6 +1255,12 @@ kPersistentCongestionThreshold:
 Variables required to implement the congestion control mechanisms
 are described in this section.
 
+max_datagram_size:
+: The sender's current maximum payload size. Does not include UDP or IP
+  overhead.  The max datagram size is used for calculating initial and
+  minimum congestion windows. The RECOMMENDED value is 1200 bytes, may be

I think this is actually wrong. (i) It's used for computing cwnd increases as well, but I would drop that list, and (ii) we don't need to recommend 1200, we need to require at least 1200, in keeping with the transport draft.

```suggestion
The sender's current maximum payload size. Does not include UDP or IP overhead.  The max datagram size is used for calculating  minimum congestion windows. An endpoint sets the value of this variable based on its PMTU, with a minimum value of 1200 bytes (see Section 14 of {{QUIC-TRANSPORT}}).
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3167#pullrequestreview-308887171