Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 685C91200A3 for ; Tue, 29 Oct 2019 16:25:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -7.999 X-Spam-Level: X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xdVnKRra6wXB for ; Tue, 29 Oct 2019 16:25:05 -0700 (PDT) Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C69F12006D for ; Tue, 29 Oct 2019 16:25:05 -0700 (PDT) Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id A9892A039C for ; Tue, 29 Oct 2019 16:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572391504; bh=l2PPPxE4i3xNaBk4S/df3h5uTmcxbJ/xEeICcWvWfdQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YsLcMrCVtAVn2RfssqLa8G+EunfuzaRvjz+3rtJbr3g8hl1yLPnKj2Tc0CxTE9ktX Rk0TWGSB4kOqDpXSHn4y+Bgztb8z2LKCMeBZIIOJ2rCQ85s5B/pUErmTgf58ggqlYY BJojcxU6g3cpSAzDfLhRKdHoaKOwuic/dnzm2cmE= Date: Tue, 29 Oct 2019 16:25:04 -0700 From: Jana Iyengar Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5db8ca509a58a_769a3fc319ccd9601573ea"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: janaiyengar X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2019 23:25:08 -0000 ----==_mimepart_5db8ca509a58a_769a3fc319ccd9601573ea Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit janaiyengar requested changes on this pull request. > @@ -1258,6 +1255,12 @@ kPersistentCongestionThreshold: Variables required to implement the congestion control mechanisms are described in this section. +max_datagram_size: +: The sender's current maximum payload size. Does not include UDP or IP + overhead. The max datagram size is used for calculating initial and + minimum congestion windows. The RECOMMENDED value is 1200 bytes, may be I think this is actually wrong. (i) It's used for computing cwnd increases as well, but I would drop that list, and (ii) we don't need to recommend 1200, we need to require at least 1200, in keeping with the transport draft. ```suggestion The sender's current maximum payload size. Does not include UDP or IP overhead. The max datagram size is used for calculating minimum congestion windows. An endpoint sets the value of this variable based on its PMTU, with a minimum value of 1200 bytes (see Section 14 of {{QUIC-TRANSPORT}}). ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3167#pullrequestreview-308887171 ----==_mimepart_5db8ca509a58a_769a3fc319ccd9601573ea Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@janaiyengar requested changes on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
> @@ -1258,6 +1255,12 @@ kPersistentCongesti=
onThreshold:=0D
 Variables required to implement the congestion control mechanisms=0D
 are described in this section.=0D
 =0D
+max_datagram_size:=0D
+: The sender's current maximum payload size. Does not include UDP or=
 IP=0D
+  overhead.  The max datagram size is used for calculating initial and=0D=

+  minimum congestion windows. The RECOMMENDED value is 1200 bytes, may b=
e=0D
=0D

I think this is actually wrong. (i) It's used for computing cwnd incre= ases as well, but I would drop that list, and (ii) we don't need to recom= mend 1200, we need to require at least 1200, in keeping with the transpor= t draft.

=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-  minimum congestion windows. The RECOMMENDED=
 value is 1200 bytes, may be=0D
+The sender's current maximum payload size. Does not include UDP or IP ov=
erhead.  The max datagram size is used for calculating  minimum congestio=
n windows. An endpoint sets the value of this variable based on its PMTU,=
 with a minimum value of 1200 bytes (see Section 14 of {{QUIC-TRANSPORT}}=
).=0D
=0D =0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or unsubscribe= .3D""<= /p>=0D = ----==_mimepart_5db8ca509a58a_769a3fc319ccd9601573ea--