IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add max_ack_delay transport parameter and ACK every two packets (#1781)

Christian Huitema <notifications@github.com> Mon, 24 September 2018 01:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 474A6130DEC for <quic-issues@ietfa.amsl.com>; Sun, 23 Sep 2018 18:42:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L1Vpsqs9dRYQ for <quic-issues@ietfa.amsl.com>; Sun, 23 Sep 2018 18:42:12 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C788128CE4 for <quic-issues@ietf.org>; Sun, 23 Sep 2018 18:42:12 -0700 (PDT)
Date: Sun, 23 Sep 2018 18:42:11 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537753331; bh=kxWVvUzSxvRHa3Nei1jnVeZaFGfhlTQmSa06ckmMim8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0Wj8xL3cmOMJEhTOXUC4zMmM0NU57wJDH7la7nGv78ydpAKWdF/2xxUOq7jMSv65T OeUdCgtTs//jOdyPFinRPetGnGB8s4v7ZMZVU4Z1bRYS/TOjYBkD06VQrKJwkmCqAv VB6y2aE7/QqQWUKynGJp0LFo/VXSZPKBfMsjVVf4=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abea440c7b2a8c60b2f25c4e5022bb5c9cb296bf3d92cf0000000117c002f392a169ce1599ab93@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1781/review/157961709@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1781@github.com>
References: <quicwg/base-drafts/pull/1781@github.com>
Subject: Re: [quicwg/base-drafts] Add max_ack_delay transport parameter and ACK every two packets (#1781)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba840f33dc3c_6fff3ffa036d45c41655ef"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kfIO8iXPZRKKNSP_WO3S35ICJZM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2018 01:42:14 -0000

huitema commented on this pull request.



> @@ -1674,6 +1675,12 @@ disable_migration (0x0009):
   address other than that used to perform the handshake.  This parameter is a
   zero-length value.
 
+max_ack_delay (0x000c):
+
+: An 8 bit unsigned integer value indicating the maximum amount of time in

I agree that it would be helpful. The only reference to ACK Delay in the transport draft is in the description of the ACK frame. The ACK generation is described in the recovery draft, using a parameter kDelayedAckTimeout. Max ACK Delay is also defined in the recovery draft, but the section 4.1.1 appears obsolete. In light of that, the proper phrase is probably "maximum time that the peer will wait before acknowledging a packet" plus a reference to the appropriate section of the recovery draft. This PR should probably also update the recovery draft.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1781#discussion_r219720183

v2.23.0 | Report a Bug | By Email