Re: [quicwg/base-drafts] introduce a version alias mechanism (#2573)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

As noted on the list, a few major items:

* This might be better as a NEW_TOKEN addition.
* This needs more thorough treatment of linkability.
* Some discussion of how to generate these values would be advisable.  That doesn't need to include the tricky bit, which is how you manage this in anticipation of the deployment of a new version, but it does need to have at least an example of how to do this without messing it up.

> @@ -4115,6 +4130,25 @@ preferred_address (0x000d):
 ~~~
 {: #fig-preferred-address title="Preferred Address format"}
 
+version_aliases (0x000e):
+
+: A list of version numbers that the server accepts as an alias for the
+  currently used versions. This transport parameter is only sent by the server.
+  Every version alias contains a lifetime in seconds. The alias is only valid
+  for that lifetime, clients MUST NOT use it after expiry.
+
+~~~
+   struct {
+     uint32 VersionNumber;
+     varint Lifetime;
+     opaque InitialSecret<20>;

You want `opaque InitialSalt[20];` or `opaque InitialSalt<20..32>;`  with appropriate values for minimum and maximum.
```suggestion
     opaque initial_secret[20];
```

> @@ -4115,6 +4130,25 @@ preferred_address (0x000d):
 ~~~
 {: #fig-preferred-address title="Preferred Address format"}
 
+version_aliases (0x000e):
+
+: A list of version numbers that the server accepts as an alias for the
+  currently used versions. This transport parameter is only sent by the server.
+  Every version alias contains a lifetime in seconds. The alias is only valid
+  for that lifetime, clients MUST NOT use it after expiry.
+
+~~~
+   struct {
+     uint32 VersionNumber;
+     varint Lifetime;

```suggestion
     uint32 lifetime_ms;
```

As others have suggested, include the units.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2573#pullrequestreview-224167569