Re: [quicwg/base-drafts] Added a word of caution before abandoning Initial packets (#3416)

ianswett <notifications@github.com> Wed, 05 February 2020 17:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D575D1200B2 for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 09:56:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9zstRwsG7wHi for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 09:56:44 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CAC57120077 for <quic-issues@ietf.org>; Wed, 5 Feb 2020 09:56:43 -0800 (PST)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id D17D552018B for <quic-issues@ietf.org>; Wed, 5 Feb 2020 09:56:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580925401; bh=AcKEaUu3ogrB8G0ARroe5kglR3Que70lQamXoSx97T0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Q+j5+N2hM3nGU6+02tC0ZDi5YH3BspdrWNM1JZzWkffGG5A5ONKMq7Imz3JU3KFwB OYSXBpZTUnRrmi4EqnBRDrBjYgDY32ZD8WnDrsbklDbWOLBtk7MYD9PCQ3+5V5FJEA i45X7UCGBge0M+WV6juEFxiDRzWA2prWvlYXNDqY=
Date: Wed, 05 Feb 2020 09:56:41 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5MHN4AO2P7VYUB6X54JA2FTEVBNHHCCZCBQI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3416/review/353921559@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3416@github.com>
References: <quicwg/base-drafts/pull/3416@github.com>
Subject: Re: [quicwg/base-drafts] Added a word of caution before abandoning Initial packets (#3416)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e3b01d9c18cd_14453fd4866cd960284993"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kqjVPUTP29OVztRgRmbMST9MSUU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2020 17:56:46 -0000

ianswett commented on this pull request.



> @@ -3700,7 +3700,9 @@ when it receives its first Handshake packet.  Though packets might still be in
 flight or awaiting acknowledgment, no further Initial packets need to be
 exchanged beyond this point.  Initial packet protection keys are discarded (see
 Section 4.10 of {{QUIC-TLS}}) along with any loss recovery and congestion
-control state (see Sections 5.3.1.2 and 6.9 of {{QUIC-RECOVERY}}).
+control state (see Sections 5.3.1.2 and 6.9 of {{QUIC-RECOVERY}}). This is safe
+because of the additional safeguards against loss of Handshake packets in

The packets need to be repeated to avoid deadlock and to ensure the handshake completes, but not in order to be sure that the CRYPTO data sent in Initial has arrived.

I suspect I'm missing something here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3416#discussion_r375413847