Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)

Martin Thomson <notifications@github.com> Mon, 24 August 2020 03:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D90F13A0999 for <quic-issues@ietfa.amsl.com>; Sun, 23 Aug 2020 20:42:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.081
X-Spam-Level:
X-Spam-Status: No, score=0.081 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CKZSl4UlDAxv for <quic-issues@ietfa.amsl.com>; Sun, 23 Aug 2020 20:42:19 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B2B523A0995 for <quic-issues@ietf.org>; Sun, 23 Aug 2020 20:42:19 -0700 (PDT)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id 45A91840748 for <quic-issues@ietf.org>; Sun, 23 Aug 2020 20:42:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598240538; bh=s5VFK90atfzs5qQMdvK1h2ym0Hv5lqfgG9H3raWWOKU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zd9vwKhGvsK5NeT+lYE0180pEG70wcK7BDKDKW+xsfpCrYZHAvoPC4EHM0xyTSg2j e4mynNdpjEvCeTKdBif1SgrKoYct6HNl403c/kOMelsAxQRb08dZas6S7d58RjRyjI Jk0B6lm/7vyyTyp2Rcb7lj73ErA1PS0S73yFm9VE=
Date: Sun, 23 Aug 2020 20:42:18 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2TUA5ZXXX5A2NII7V5J4MBVEVBNHHCREMQGU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4010/c678887472@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4010@github.com>
References: <quicwg/base-drafts/pull/4010@github.com>
Subject: Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f43371a35e28_190f196416252fe"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ksqYcCL_gdPP3hjaCeiH61brwmM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2020 03:42:21 -0000

Thanks for reviewing @kazu-yamamoto.

Regarding the global sequence space, I figure that you can do this without a global sequence number in other ways.  For instance, you could track the sending time of all outstanding packets or you could enter all outstanding packets into a linked list, either of which allows you to establish a total ordering.  (In the absence of a single sequence number space, I decided not to do a total global ordering on the basis that detecting persistent congestion during the handshake was not so important.)

For the other points, the goal of this is to explain above any requirement to be performant.  You can, as I suggest in commit comments, drop pc_lost more often to limit the overhead.  It is a fair bit more complex to fit into the spec though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4010#issuecomment-678887472