IETF Logo Mail Archive

Re: [quicwg/base-drafts] First byte changes (#2006)

Mike Bishop <notifications@github.com> Mon, 19 November 2018 17:41 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F0157130DDA for <quic-issues@ietfa.amsl.com>; Mon, 19 Nov 2018 09:41:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XxPr0NeQ-vjV for <quic-issues@ietfa.amsl.com>; Mon, 19 Nov 2018 09:41:09 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D56EA130DC7 for <quic-issues@ietf.org>; Mon, 19 Nov 2018 09:41:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=dZ9TfDgLfQIw3XwN0zTnGwWdjYo=; b=ayiYqh3D2f5jx0hg 8DhhJlFNHE3BYAaXpK8e677ZN1hsne4olkrYBZt3Or/44AgE714c7xoGdIlg/zr1 Ix5kgdagMoWg/C0EX2sWpiuIEui0ta4dKOa6twqLO0yd/fhWrE3sksTklHx/An97 s/caPcKTDVIgBZkEjmF1k1yF+0k=
Received: by filter1070p1las1.sendgrid.net with SMTP id filter1070p1las1-6761-5BF2F5B2-10 2018-11-19 17:41:06.795164236 +0000 UTC m=+169860.066285574
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0033p1mdw1.sendgrid.net (SG) with ESMTP id cNAZWg2nTHaOwsRO7HbX4g for <quic-issues@ietf.org>; Mon, 19 Nov 2018 17:41:06.816 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id 92DC7160324 for <quic-issues@ietf.org>; Mon, 19 Nov 2018 09:41:06 -0800 (PST)
Date: Mon, 19 Nov 2018 17:41:07 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9c2541930d55e14fecdb161bb7041a776312acc792cf00000001180ab7b292a169ce16b57ba1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2006/review/176417101@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2006@github.com>
References: <quicwg/base-drafts/pull/2006@github.com>
Subject: Re: [quicwg/base-drafts] First byte changes (#2006)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf2f5b290ea0_63b63fa006ad45b82077d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0hHEj+rQHK1/1AV5/9pna8Q+ymVsc1ZisXd9 /ZJsMX7aN2cPQes8umhenR+Yy5L87i71V4fz8kesvsXd9j7H4CEte4ArGDRMfb/khfjeR5Rhdh7iS0 EjY/mdzRG4MFX0mxN+3/8c+iWkfDdv5w/mJtg4bjDP8Tft3pHgVou8aPU1Uv7vucM7xRixkT+geaPg s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kyOEZLtRYLZZ2TRkrqv2Wr8nNHQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Nov 2018 17:41:11 -0000

MikeBishop commented on this pull request.



>  
-: The fourth bit (0x10) of byte 0 is set to 1.
+: The next two bits (those with a mask of 0x18) of byte 0 are reserved.  These
+  bits are protected using header protection (see Section 5.4 of
+  {{QUIC-TLS}}).  The value included prior to protection MUST be set to 0.  An

Because otherwise they become scratch space where a middlebox could place a persistent marking on the packets.  If peers want to discard integrity checks on some portion of the data they send/receive, they can certainly do so -- but not unilaterally.  By default, modification of the packet makes the packet invalid.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2006#discussion_r234715851

v2.39.1 | Report a Bug | By Email | System Status