IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)

Nick Banks <notifications@github.com> Tue, 18 December 2018 14:23 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE842126BED for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 06:23:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8k0ZDvfx01K8 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 06:23:50 -0800 (PST)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B3B981200B3 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 06:23:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=0H6WOdiVpWIkuuiKMHreNgajXbY=; b=SKbgc6Clx/g7g4Dc SMH+fcdQYMLEeE7G77z/4nMvrUx7B05AQOCzhCVxfcgrs3Tj2MwKspG2MlTEaoBY DqMx5MXah3Nf9r62bwPIVtdrsFhlqNl4Syqo8384jrMN2fEYUHnT8A1jK32SMpkt x8+gr0pAvMeXKTPd7urmszohuGU=
Received: by filter0438p1iad2.sendgrid.net with SMTP id filter0438p1iad2-29135-5C1902F2-32 2018-12-18 14:23:46.370059978 +0000 UTC m=+72216.994914159
Received: from github-lowworker-39ccb07.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0001p1iad2.sendgrid.net (SG) with ESMTP id kd_bc-tiRHCH6e-gtuvFaA for <quic-issues@ietf.org>; Tue, 18 Dec 2018 14:23:46.361 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-39ccb07.cp1-iad.github.net (Postfix) with ESMTP id 6C4DB4000AB for <quic-issues@ietf.org>; Tue, 18 Dec 2018 06:23:46 -0800 (PST)
Date: Tue, 18 Dec 2018 14:23:47 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4a80c5ae343ea3761f2667a6f9f0a24014e07c2a92cf000000011830c4f292a169ce175c9b40@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2203/review/186091071@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2203@github.com>
References: <quicwg/base-drafts/pull/2203@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1902f26af34_39ad3febd6cd45b842721"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0KfaS7SZ/f1+QTTZZuujq3FqL29z3cZJ+YNo mayrQZ4icI++wbYaH4pRd8+nbJTyJzBWXJbHMEKyCRK7kX8Ou33quRMQV5JOHMvFIZIDl5jsFwiK3q IfnzZ6vB/YSf0L+6bhoza2uftUKKrcYEEFo1+XXlHJg42s4UUp3box5PFZ1yfGtwb+7mflP5uDKXcy Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kyY54cDs5rTMps-2t-xitDjsSEU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 14:23:52 -0000

nibanks commented on this pull request.

Everything looks good besides the one comment/question I had on the starting packet number.

> @@ -2658,7 +2663,7 @@ level and can only be acknowledged in Handshake packets.
 
 This enforces cryptographic separation between the data sent in the different
 packet sequence number spaces.  Each packet number space starts at packet number
-0.  Subsequent packets sent in the same packet number space MUST increase the
+1.  Subsequent packets sent in the same packet number space MUST increase the

Why was this changed from `0` to `1`? Other places in the text still say packet numbers start at `0`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2203#pullrequestreview-186091071

v2.23.0 | Report a Bug | By Email