Re: [quicwg/base-drafts] editorial advice for h2<->h3 error propagation (#3602)

Mike Bishop <notifications@github.com> Thu, 30 April 2020 15:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22C303A111E for <quic-issues@ietfa.amsl.com>; Thu, 30 Apr 2020 08:42:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.008
X-Spam-Level:
X-Spam-Status: No, score=-2.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ehM2mCJQGPyM for <quic-issues@ietfa.amsl.com>; Thu, 30 Apr 2020 08:42:31 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 632423A0D30 for <quic-issues@ietf.org>; Thu, 30 Apr 2020 08:41:34 -0700 (PDT)
Received: from github-lowworker-d1d6e31.ash1-iad.github.net (github-lowworker-d1d6e31.ash1-iad.github.net [10.56.105.50]) by smtp.github.com (Postfix) with ESMTP id 8E874C61B4E for <quic-issues@ietf.org>; Thu, 30 Apr 2020 08:41:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588261292; bh=hY7dzW4W6AXCcJ+hvdh+SbfPMHigPO6/3bOhbfpSd1Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=R/kmtQl+gJ2WS1db300QpBH2ep8Kx6Fe8bRmo3lGQ6Y/2VX4XVKWY642celYFX801 85n1u4RuK1jstrJ7fJ5uwxdGmwjupAUcYM8HWj8ophR4o+dNhM40XMGxDka31GoVqX yskyduffFaLh4T/lrGr/8XT6FUWDbq5YxpLe+EDA=
Date: Thu, 30 Apr 2020 08:41:32 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYNDF7IQYSSONFJ3654W3JKZEVBNHHCIQTSZE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3602/review/403643922@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3602@github.com>
References: <quicwg/base-drafts/pull/3602@github.com>
Subject: Re: [quicwg/base-drafts] editorial advice for h2<->h3 error propagation (#3602)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eaaf1ac7edf5_26fe3ff3470cd968554cc"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kzC5CRFC6kHS7A9jQ4LU9FXUtA4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 15:42:39 -0000

@MikeBishop requested changes on this pull request.

I think I'd invert the polarity of this, based on what I recall of the list discussion.  Error codes largely reflect connection-local issues and mostly shouldn't be propagated.  I'm inclined to lead with indicating an upstream  failure via the HTTP status codes, then note that there are times it might be useful to proxy a specific stream error, such as REFUSED_STREAM.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3602#pullrequestreview-403643922