Re: [quicwg/base-drafts] Update ACK generation policy (#3501)

Gorry Fairhurst <notifications@github.com> Sun, 22 March 2020 19:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8BC53A0873 for <quic-issues@ietfa.amsl.com>; Sun, 22 Mar 2020 12:48:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MGmorj2QvID0 for <quic-issues@ietfa.amsl.com>; Sun, 22 Mar 2020 12:48:42 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4AE83A046E for <quic-issues@ietf.org>; Sun, 22 Mar 2020 12:48:22 -0700 (PDT)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id 69182521EB9 for <quic-issues@ietf.org>; Sun, 22 Mar 2020 12:48:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584906501; bh=TZwLycKEn2YSGCu0JhcKaHTp37d0aVTTVz7YCJlZf3Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZAjoDgav7m6mcG72oiOIPXKoftiZNk4tgKEJdbUOMl0s6y1mZVQB1P6TqYmiaMDJ/ oYD/MeVJhaUiBGSZDFR4DzxfsSQ89euzs7aG0oGA3Zy+3NxwOwKHt1p6MCPXZTxGh6 7QlzSC5D5jcvhcn6/IZxNuZutD4+2+bmIXpi7e3A=
Date: Sun, 22 Mar 2020 12:48:21 -0700
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZVMW55T2BO5FNZQKV4QORALEVBNHHCEV4TFI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3501/review/379040817@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3501@github.com>
References: <quicwg/base-drafts/pull/3501@github.com>
Subject: Re: [quicwg/base-drafts] Update ACK generation policy (#3501)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e77c1055513d_4dc43f950e4cd960459b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kzgunOjYsawv7oU49Qzl4P8b9DQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Mar 2020 19:48:44 -0000

gorryfair commented on this pull request.



> @@ -3170,11 +3170,21 @@ delayed retransmissions from the peer. For Initial and Handshake packets,
 a max_ack_delay of 0 is used. The sender uses the receiver's `max_ack_delay`
 value in determining timeouts for timer-based retransmission, as detailed in
 Section 5.2.1 of {{QUIC-RECOVERY}}.
+The max_ack_delay needs to be set so that at least several samples can

Bah, OK. Not sure why its designed that way - but let's live with that. A different way, is for a receiver with an RTT sample to use that to achieve the same outcome at the receiver?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3501#discussion_r396133450