IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)

Rui Paulo <notifications@github.com> Tue, 17 July 2018 18:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 390C6130E21 for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 11:33:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZHpmpPWGc3b3 for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 11:33:04 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B6F50130DF3 for <quic-issues@ietf.org>; Tue, 17 Jul 2018 11:33:04 -0700 (PDT)
Date: Tue, 17 Jul 2018 11:33:04 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531852384; bh=HrV1eqKRY+rAk/ndCSL3ADdY8QXJO4gx+IIKoJ1O9ro=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S3vLbL30pnDPcndzc4xEeHTkXP8IaQBmYgYskuj570VYh5uLXigaJq57NRY14f3+m JWGKlmi90MFIYA9BhzQAJVEstXexkG94V5iI1L0Efah75PlNqwxrlUCKlmXJXRf3An +T7+54cnnyHgDTcrbn6XmNq9e5Vpnzojl5f91SF8=
From: Rui Paulo <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7c6a861f6082ff4a63e63504e1a601543515b3d892cf000000011765f86092a169ce1461f5c3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1574/review/137963604@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1574@github.com>
References: <quicwg/base-drafts/pull/1574@github.com>
Subject: Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4e3660c607_1af2b03c7f20f581170f2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: rpaulo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l1lVEIApc9PjAWqt4rheqIF41D0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jul 2018 18:33:07 -0000

rpaulo commented on this pull request.



> @@ -338,15 +351,10 @@ conditions:
 * If RTO ({{rto}}) is earlier, schedule a TLP in its place. That is,
   PTO SHOULD be scheduled for min(RTO, PTO).
 
-MaxAckDelay is the maximum ack delay supplied in an incoming ACK frame.
-MaxAckDelay excludes ack delays that aren't included in an RTT sample because
-they're too large and excludes those which reference an ack-only packet.
-
-QUIC diverges from TCP by calculating MaxAckDelay dynamically, instead of
-assuming a constant delayed ack timeout for all connections.  QUIC includes this
-in all probe timeouts, because it assume the ack delay may come into play,
-regardless of the number of packets outstanding.  TCP's TLP assumes if at least
-2 packets are outstanding, acks will not be delayed.
+QUIC includes MaxAckDelay in all probe timeouts, because it assume the ack

"assumes"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1574#pullrequestreview-137963604

v2.23.0 | Report a Bug | By Email