Re: [quicwg/base-drafts] Handling of duplicate packets (#1405)

Martin Thomson <notifications@github.com> Thu, 31 May 2018 23:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A91C2127863 for <quic-issues@ietfa.amsl.com>; Thu, 31 May 2018 16:13:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tGKsx5ehmnpu for <quic-issues@ietfa.amsl.com>; Thu, 31 May 2018 16:13:41 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B0D15127735 for <quic-issues@ietf.org>; Thu, 31 May 2018 16:13:41 -0700 (PDT)
Date: Thu, 31 May 2018 16:13:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1527808419; bh=Og5+5GLBDcCwxXihlgSWdmxwD1Ut6V+Bl2uVqKAHcdc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=T6rxOT/fXNWA0PDe1IhLC0GOWcITR/Pa0cCM5ZODGrt449QN2GFLpJfa5jMtW0PoD 6MCiG2XXE+QlH5DHyHNVKIAKMAaIAegqf90VnYcxDd1lilI2+BXZH1jOw4UEdZ1Sm+ 91AfLGxRyg54qTjAnzkpXqb+oktR06by8LvA+9WM=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abee17b4b06020d0745709839e1623338dd2528cea92cf00000001172843a392a169ce138d6870@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1405/393711328@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1405@github.com>
References: <quicwg/base-drafts/issues/1405@github.com>
Subject: Re: [quicwg/base-drafts] Handling of duplicate packets (#1405)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1081a3ce5e5_288873fef081aef78552ec"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l2DBPv5rjTOuWVpCadCGebNvNKc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2018 23:13:44 -0000

We can probably crib something from DTLS.  The usual method is to maintain a bitvector for the last N packets, and to drop anything that appears to be before that vector starts.  The point about stateless reset is a good one, and one I discovered when implementing it.  It's highly likely that a stateless reset will appear to be a duplicate.

One thing we need to observe is that we won't be checking that the packet is a true duplicate, only that we've (probably) seen the (apparent) packet number before.

Another thing here is that packets that are ECN marked, but not authenticated, might be carrying a valid congestion signal, but we drop those too.  Think about the usual background radiation on the Internet that passes through a congested link on its way to you.  I don't think that we need to worry about that though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1405#issuecomment-393711328