IETF Logo Mail Archive

Re: [quicwg/base-drafts] One close frames (#1900)

ianswett <notifications@github.com> Wed, 24 October 2018 12:57 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 48197130EDD for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 05:57:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ge3VB17taxfJ for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 05:57:36 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9358130E91 for <quic-issues@ietf.org>; Wed, 24 Oct 2018 05:57:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=hzz5fhdEMHLo/rcVovWq54up5Ww=; b=WS3W5LgsnjiRDGIJ 1Vko3mEqhPHrhbrk/pdoTImJqJ46g53fDo/Vwy/wOYycHTq83VRs/URPigBHKODQ NCJmz00T+uEeQ93JEaIjJTJoYLK3z54bqqHe9+gckRxw48nTuTn2gs+IUARvt7xH awYyDwh1a4zXHX2vJ+pBh/2B7ds=
Received: by filter0138p1iad2.sendgrid.net with SMTP id filter0138p1iad2-8058-5BD06C3D-26 2018-10-24 12:57:33.773765716 +0000 UTC m=+469135.994999099
Received: from github-lowworker-dcc078e.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0021p1iad2.sendgrid.net (SG) with ESMTP id q7k3Iw-gRKCEKAs2OEh1aQ for <quic-issues@ietf.org>; Wed, 24 Oct 2018 12:57:33.786 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcc078e.cp1-iad.github.net (Postfix) with ESMTP id B79C42C06B3 for <quic-issues@ietf.org>; Wed, 24 Oct 2018 05:57:33 -0700 (PDT)
Date: Wed, 24 Oct 2018 12:57:33 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5f4001f306d6cfc3829a8a5b402c578c58516a5292cf0000000117e82e3d92a169ce164012de@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1900/review/167891540@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1900@github.com>
References: <quicwg/base-drafts/pull/1900@github.com>
Subject: Re: [quicwg/base-drafts] One close frames (#1900)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd06c3db5f0c_13723fb9bc6d45c4706930"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3iECiZ/1RCQyoibD6uzPfLXrT9R6LEItdphv eyOvJ6szguK9r5raVlmQDRDKoCjwKWGejfOnpbbuoOFA6QVXQI6jB9jSiWm7Wtapa4OkMgjq6wX7ZS vHyF8ahlTQEwa55y6Xw9ggBxetY/qSj85t+bI72ne47gCMUJcTh9UQ/LCg==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l4fSu_4JWJ7b5u4nWb3AX7uRXp0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 12:57:44 -0000

ianswett commented on this pull request.



> @@ -1268,8 +1268,9 @@ express the cause of a connection or stream error.
 
 ## HTTP/QUIC Error Codes {#http-error-codes}
 
-The following error codes are defined for use in QUIC RST_STREAM, STOP_SENDING,
-and APPLICATION_CLOSE frames when using HTTP/QUIC.
+The following error codes are defined for use in QUIC RST_STREAM frames,
+STOP_SENDING frames, and CONNECTION_CLOSE frames with a type of 0x03 when using
+HTTP/QUIC.

I tend to agree, I'd remove the type reference.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1900#discussion_r227775547

v2.28.0 | Report a Bug | By Email | System Status