IETF Logo Mail Archive

Re: [quicwg/base-drafts] Change error codes from 16-bit to varints (#2680)

Martin Thomson <notifications@github.com> Thu, 09 May 2019 23:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1BE01201EE for <quic-issues@ietfa.amsl.com>; Thu, 9 May 2019 16:12:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.606
X-Spam-Level:
X-Spam-Status: No, score=-6.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aX9PCAW2yrsp for <quic-issues@ietfa.amsl.com>; Thu, 9 May 2019 16:12:03 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CDC4A1200DE for <quic-issues@ietf.org>; Thu, 9 May 2019 16:12:03 -0700 (PDT)
Date: Thu, 09 May 2019 16:12:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557443522; bh=xIWPH/isZ+iQbLZl80Fa6K/BLU3X6AV8rQpu9fdBC+o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QX4gPQcoD2XleZ/dIeJ9CIjbht+vpR3Ohxw6G+xEfEaYpPp3i4sirgsAzQhSXNhQO 4IVftTUOgD+J7jo6od6SiJKXoYAWwy340C9gkDT2f6MO9Vy0IISaoeG5SbRcD9deO/ Pm3lzyJtzedduSwo1K2stvG2yde6DP1leN6wy3Os=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7NR564Y2DGYF2ZS2V24HTEFEVBNHHBUXBX44@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2680/review/235865595@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2680@github.com>
References: <quicwg/base-drafts/pull/2680@github.com>
Subject: Re: [quicwg/base-drafts] Change error codes from 16-bit to varints (#2680)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd4b3c2793fc_685d3fb8f82cd9689847f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l84tC6mTbcT4MjlPbGHFy7PzsKQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 23:12:11 -0000

martinthomson requested changes on this pull request.

Two relatively important things here.

> @@ -5550,7 +5554,7 @@ The initial contents of this registry are tabulated in {{frame-types}}.
 IANA \[SHALL add/has added] a registry for "QUIC Transport Error Codes" under a
 "QUIC Protocol" heading.
 
-The "QUIC Transport Error Codes" registry governs a 16-bit space.  This space is
+The "QUIC Transport Error Codes" registry governs a 62-bit space.  This space is
 split into two spaces that are governed by different policies.  Values with the

I think that we want to crib from the frame types (or other varint registries) when it comes to policies.  There isn't really a "first byte" any more.

> @@ -5456,7 +5460,7 @@ ID can be selected to route later packets to the same server.
 IANA \[SHALL add/has added] a registry for "QUIC Transport Parameters" under a
 "QUIC Protocol" heading.
 
-The "QUIC Transport Parameters" registry governs a 16-bit space.  This space is

You overdid it here.  It's still 16 for transport parameters.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2680#pullrequestreview-235865595

v2.23.0 | Report a Bug | By Email