IETF Logo Mail Archive

Re: [quicwg/base-drafts] No octets (#1921)

Martin Thomson <notifications@github.com> Sun, 28 October 2018 23:27 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82D97120072 for <quic-issues@ietfa.amsl.com>; Sun, 28 Oct 2018 16:27:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UbKpFZfkmfNj for <quic-issues@ietfa.amsl.com>; Sun, 28 Oct 2018 16:27:55 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 810F212870E for <quic-issues@ietf.org>; Sun, 28 Oct 2018 16:27:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=HcDDbMDe3DF0jJQCqtA0AZGb304=; b=CtiYpolift52RcDD 1+G5zfn+RfPXi3CNr1e607MfI1ZRnAbqefHkfWf3O9Y5fSODr97kY0OBlgebpKAW zDZMjmew4SaYPy8zqzIn4x0Of2MKSKR2mYmbKNxKwR2GKxSRgsoRQH/W2wzq34Fc ltOi6NOxRNPELK80ljyVFz8cROs=
Received: by filter1123p1las1.sendgrid.net with SMTP id filter1123p1las1-2949-5BD645F9-16 2018-10-28 23:27:53.892157191 +0000 UTC m=+865320.934648337
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) by ismtpd0033p1mdw1.sendgrid.net (SG) with ESMTP id 7tcxCtVYT8OLv-jfgMatRg for <quic-issues@ietf.org>; Sun, 28 Oct 2018 23:27:53.532 +0000 (UTC)
Date: Sun, 28 Oct 2018 23:27:54 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab72938e70744c7a4621a6ac565cd676fc2675fa2f92cf0000000117ee07f892a169ce164d89cf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1921/review/169115687@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1921@github.com>
References: <quicwg/base-drafts/pull/1921@github.com>
Subject: Re: [quicwg/base-drafts] No octets (#1921)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd645f8c1b12_13e43fb8ea0d45c02276196"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0zHE1ensZJxOX5kmEuDXAwyvkkYxuRx8vIIl aXU1y2lzrN6R+d7Lp1lU9lSzq30PiE354QzminH4utq9G9zgzI6ynEZKPLEIqWfD9A7xHHV441Z/+v wJrnoVhqZcb8g7NinUUfKGtyYTys437oM8Cp/0lm8m0wmaN073/cwiRaxamm2+c63G6F/kYpR/r786 k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l94zay1sixbS5DjeuKGK9yx8jZY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2018 23:27:58 -0000

martinthomson commented on this pull request.



> @@ -965,8 +964,8 @@ losses or increases in the ECN-CE counter.
 ## Tail Loss Probe
 
 A TLP packet MUST NOT be blocked by the sender's congestion controller. The
-sender MUST however count these bytes as additional bytes-in-flight, since a TLP
-adds network load without establishing packet loss.
+sender MUST however count TLP packets against bytes-in-flight, since a TLP adds

```suggestion
sender MUST however count TLP packets against bytes in flight, since a TLP adds
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1921#pullrequestreview-169115687

v2.36.0 | Report a Bug | By Email | System Status