Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)
Kazuho Oku <notifications@github.com> Tue, 05 November 2019 02:37 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E76812004D for <quic-issues@ietfa.amsl.com>; Mon, 4 Nov 2019 18:37:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L5acHbIgQ8lF for <quic-issues@ietfa.amsl.com>; Mon, 4 Nov 2019 18:37:15 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 91685120033 for <quic-issues@ietf.org>; Mon, 4 Nov 2019 18:37:15 -0800 (PST)
Date: Mon, 04 Nov 2019 18:37:14 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572921434; bh=eaQj3r9z1nw5NqeFN4HSpVyxBFRXervitN0NgQQ1JPY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aBmnFgzCTbV4Rm/kllwkczEfeOo5ST4ezTqsPZdbSE32mNJaECXgE4luLGWEecdaS nx6/Y67KIsVtIsZaugRltAoure9zYhbUvlpeMy0/0dOgCaldFudKX/cG/Ic6m6Idj3 wBQkK9wk+sJWiX4UEcrU28FRZ9wTHT/PvQ5iHdbY=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4PU3MU5IZUC3PWTYF3ZYJNVEVBNHHB5UBVKI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3186/c549637548@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3186@github.com>
References: <quicwg/base-drafts/pull/3186@github.com>
Subject: Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc0e05a898e8_1f733fc168ecd95c114418"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l9Uiu7X8jB6C5gabWachQICIYL0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2019 02:37:17 -0000
@ianswett @janaiyengar I am with @marten-seemann. Let me explain why. There are two reasons we decided to allow use of FLOW_CONTROL_ERROR for STREAM frames: * The overflow can be detected by the flow control logic. Then, there is not need to have a logic to detect the error in the frame decoder. * The flow control logic might be capable of returning only one error. * FLOW_CONTROL_ERROR is more specific than FRAME_ENCODING_ERROR. These reasons equally hold for CRYPTO streams sending CRYPTO_BUFFER_EXCEEDED, as CRYPTO_BUFFER_EXCEEDED is the error code used to indicate flow control error with CRYPTO streams. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3186#issuecomment-549637548
- [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED… Marten Seemann
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… MikkelFJ
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… MikkelFJ
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Jana Iyengar
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Jana Iyengar
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Jana Iyengar
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Marten Seemann
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Marten Seemann
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… ianswett
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Martin Thomson
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Kazuho Oku
- Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCE… Martin Thomson