Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)

Kazuho Oku <> Tue, 05 November 2019 02:37 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 2E76812004D for <>; Mon, 4 Nov 2019 18:37:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id L5acHbIgQ8lF for <>; Mon, 4 Nov 2019 18:37:15 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 91685120033 for <>; Mon, 4 Nov 2019 18:37:15 -0800 (PST)
Date: Mon, 04 Nov 2019 18:37:14 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1572921434; bh=eaQj3r9z1nw5NqeFN4HSpVyxBFRXervitN0NgQQ1JPY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aBmnFgzCTbV4Rm/kllwkczEfeOo5ST4ezTqsPZdbSE32mNJaECXgE4luLGWEecdaS nx6/Y67KIsVtIsZaugRltAoure9zYhbUvlpeMy0/0dOgCaldFudKX/cG/Ic6m6Idj3 wBQkK9wk+sJWiX4UEcrU28FRZ9wTHT/PvQ5iHdbY=
From: Kazuho Oku <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3186/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc0e05a898e8_1f733fc168ecd95c114418"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Tue, 05 Nov 2019 02:37:17 -0000

@ianswett @janaiyengar I am with @marten-seemann. Let me explain why.

There are two reasons we decided to allow use of FLOW_CONTROL_ERROR for STREAM frames:
* The overflow can be detected by the flow control logic. Then, there is not need to have a logic to detect the error in the frame decoder.
* The flow control logic might be capable of returning only one error.

These reasons equally hold for CRYPTO streams sending CRYPTO_BUFFER_EXCEEDED, as CRYPTO_BUFFER_EXCEEDED is the error code used to indicate flow control error with CRYPTO streams.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: