Re: [quicwg/base-drafts] Don't specify RTT in HTTP (#3358)

Martin Thomson <notifications@github.com> Mon, 20 January 2020 06:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19CCC120025 for <quic-issues@ietfa.amsl.com>; Sun, 19 Jan 2020 22:23:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 62y_-qat757I for <quic-issues@ietfa.amsl.com>; Sun, 19 Jan 2020 22:23:40 -0800 (PST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6ACDD120043 for <quic-issues@ietf.org>; Sun, 19 Jan 2020 22:23:40 -0800 (PST)
Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id BF84CA10DF for <quic-issues@ietf.org>; Sun, 19 Jan 2020 22:23:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579501419; bh=bKkSiC7hOcAxKMI4vskfJ2KfFMDU843y+PHH6gFLKPQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GpqjLn+a09pE1RuJbprWVWcD1+zy5wC/dUqCwcwZuozEYUk8lE2ZTgWi9Fb/mAWdb dpAvyTEIvs3/B9fUa9lU0yucFd1u94SFsTI3jNCyAIm2eLKygfNYsPFZrfxzwjSokN TkMkAxT96FQNTmFWB4PBSMjrQjJ6unRjRvRttjOM=
Date: Sun, 19 Jan 2020 22:23:39 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6M6BUUY6JFMU3YSGV4GJ46XEVBNHHCBYIASU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3358/review/345097851@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3358@github.com>
References: <quicwg/base-drafts/pull/3358@github.com>
Subject: Re: [quicwg/base-drafts] Don't specify RTT in HTTP (#3358)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e25476bb052c_63c93fd48facd96c430cc"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lBIVM6xHtxdMCOFbuIypEilcZrc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2020 06:23:42 -0000

martinthomson commented on this pull request.

Seems alright.

> @@ -732,9 +732,10 @@ initial GOAWAY frame with the last Stream ID set to the maximum possible value
 for a client-initiated, bidirectional stream (i.e. 2^62-4 in case of QUIC
 version 1).  This GOAWAY frame signals to the client that shutdown is imminent
 and that initiating further requests is prohibited.  After allowing time for any
-in-flight requests (at least one round-trip time), the server would send another
-GOAWAY frame with an updated last Stream ID.  This ensures that a connection can
-be cleanly shut down without causing requests to fail.
+in-flight requests to reach the server, the server MAY send another GOAWAY frame
+indicating which requests it will accept before the end of the connection. This

Don't you mean "can send"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3358#pullrequestreview-345097851