Re: [quicwg/base-drafts] forbid key discarding before receiving a packet protected with new keys (#4079)

[Martin Thomson <[e-mail]>]

@martinthomson approved this pull request.

This is a good change.  The MUST regarding retention is already (strongly) implied, so it's not a normative change.  But we definitely benefit from this being direct.  I just have a tiny editorial suggestion.

> @@ -1496,10 +1496,11 @@ The endpoint that initiates a key update also updates the keys that it uses for
 receiving packets.  These keys will be needed to process packets the peer sends
 after updating.
 
-An endpoint SHOULD retain old keys so that packets sent by its peer prior to
-receiving the key update can be processed.  Discarding old keys too early can
-cause delayed packets to be discarded.  Discarding packets will be interpreted
-as packet loss by the peer and could adversely affect performance.
+An endpoint MUST retain old keys until it has successfully unprotected a packet
+sent using the new keys.  An endpoint SHOULD NOT discard old keys immediately

SHOULD NOT isn't a thing.  you want

```suggestion
sent using the new keys.  An endpoint SHOULD retain old keys for some time
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4079#pullrequestreview-484529391