Re: [quicwg/base-drafts] Add bidirectional streams on top of unidirectional (#720)

MikkelFJ <notifications@github.com> Fri, 11 August 2017 08:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF9881326DF for <quic-issues@ietfa.amsl.com>; Fri, 11 Aug 2017 01:05:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.8
X-Spam-Level:
X-Spam-Status: No, score=-9.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aq1_v21JgZUV for <quic-issues@ietfa.amsl.com>; Fri, 11 Aug 2017 01:05:09 -0700 (PDT)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext3.iad.github.net [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 280321326DE for <quic-issues@ietf.org>; Fri, 11 Aug 2017 01:05:08 -0700 (PDT)
Date: Fri, 11 Aug 2017 01:05:08 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1502438708; bh=A95tYWwbAhBLJfCiMk3z7W/cxBuhcltaoDZoZhI/ytU=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PZ0Ddceih5fs5Z6Pphv0ANQUYJt/fRM58X6S8PU7NY7kAb80pyUeK0j4L5Deeq8Yf qDJivajHnIacbmWhQGWutFsqK6mDWB25XkmeM5BszYy7tz88IK9NwGiv5zbPU7Dt9k ZbB3UlOahuoOuIcR8aA3gly5+gxVNYWVp3XOwDzs=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7e23ab387ca5c4866ba306418ac64e3d9e2ab21b92cf0000000115a5273492a169ce0edf651b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/720/review/55735227@github.com>
In-Reply-To: <quicwg/base-drafts/pull/720@github.com>
References: <quicwg/base-drafts/pull/720@github.com>
Subject: Re: [quicwg/base-drafts] Add bidirectional streams on top of unidirectional (#720)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_598d65344fa3e_59a13fe3c1335c2c842fe"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lE0j9F1YNviK_Rh-T9VM7Zb4IAc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Aug 2017 08:05:11 -0000

mikkelfj commented on this pull request.



> +This document doesn't proscribe the use of the Related Stream ID field, leaving
+decisions about the semantics of related streams to protocols that use QUIC.
+Protocols that use QUIC MUST either define the semantics of related streams or
+prohibit the use of the Related Stream ID field.  Protocols MAY define other
+uses for the Related Stream ID field, but are advised that complex relationships
+between streams could be poorly supported in generic QUIC implementations.  The
+INVALID_RELATED_STREAM error code can be used by protocols to signal receipt of
+invalid Related Stream ID field values, unless the protocol defines a more
+specific error code for the circumstances.
+
+The Related Stream ID for a stream only needs to be sent once for each (allowing
+for retransmissions due to loss).  Sending the field on all stream frames with
+an offset of 0 ensures that the value is received without duplicating the field
+unnecessarily.  If the value of the Related Stream ID changes for a stream, the
+endpoint that receives the conflicting value MUST treat this as a connection
+error of type INVALID_RELATED_STREAM.

My initial comment was thinking about packet duplicates which is not reasonable since frames are retransmitted independently of packets. However, each steam has its own retransmission filter and here  I believe the same applies: already received content should be ignored - it is not reasonable to check all received retransmission for inconsistencies, and related stream ID would just be a special case - unless I am missing something?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/720#discussion_r132633408