IETF Logo Mail Archive

Re: [quicwg/base-drafts] Editorial suggestions from Benjamin Kaduk's IESG review (qpack) (#4789)

kaduk <notifications@github.com> Wed, 27 January 2021 18:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D8733A0D69 for <quic-issues@ietfa.amsl.com>; Wed, 27 Jan 2021 10:22:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.804
X-Spam-Level:
X-Spam-Status: No, score=-1.804 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bMPtUmAmDDtR for <quic-issues@ietfa.amsl.com>; Wed, 27 Jan 2021 10:22:43 -0800 (PST)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F2173A0D64 for <quic-issues@ietf.org>; Wed, 27 Jan 2021 10:22:43 -0800 (PST)
Received: from github.com (hubbernetes-node-3734f04.ash1-iad.github.net [10.56.116.28]) by smtp.github.com (Postfix) with ESMTPA id CB8799005B4 for <quic-issues@ietf.org>; Wed, 27 Jan 2021 10:22:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1611771762; bh=Tm5l5W3cfTxHhGMLBhnDOJeM7RinybwK5uiAtxOevnY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AdFuh+KcHMdeYy+Q8ZF/438xa1cFXq/nuxYwAkRf6XNneMu+7tSakle12x1jNMZZn XFoHXAR8D1un/j89xguVWqxjWUMvhu9UQW1wCcS7HINmPZCIQM0CpW5Sv7XAl4xH+9 mDUMlZMD8zY4w+Em1tG9AodASS2YRAJljOFXhSCM=
Date: Wed, 27 Jan 2021 10:22:42 -0800
From: kaduk <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2RUNIUI7Y2FZQBNO56DWIHFEVBNHHC6HKUTI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4789/review/577631985@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4789@github.com>
References: <quicwg/base-drafts/pull/4789@github.com>
Subject: Re: [quicwg/base-drafts] Editorial suggestions from Benjamin Kaduk's IESG review (qpack) (#4789)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_6011af72c8799_611a04128823"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kaduk
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lG3bzHZDzzz2KWVCFgDdcT-n0dQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jan 2021 18:22:45 -0000

@kaduk commented on this pull request.



> @@ -1738,7 +1740,7 @@ Stream: Encoder
                               ^-- acknowledged --^
                                4   0  :authority  www.example.com
                                5   0  custom-key  custom-value2
-                              Size=215
+                              Size=214

Well crap, I can only assume that I typo'd something when checking in the shell.  Sorry about that, and thanks for double-checking.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4789#discussion_r565533963

v2.23.0 | Report a Bug | By Email