IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define INITIAL_PRIORITY frame and remove exclusive dependencies (#2075)

Lucas Pardue <notifications@github.com> Sun, 02 December 2018 21:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C657130DBE for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 13:23:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CFYaHhBpCslN for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 13:23:23 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1B60128D0C for <quic-issues@ietf.org>; Sun, 2 Dec 2018 13:23:22 -0800 (PST)
Date: Sun, 02 Dec 2018 13:23:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543785801; bh=FXMMzsOGJ7RzoozDxBl1J2yD62w+IpyAqqAzTVPVur0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=htNz0NewOTTVXwpZ2PPIXpjRFqbj/WRYvBDQJdckRXToCqWShHqiobS2p8omyYZTh iXHM5jmvQ3v6Um+GpWqt5Tj6UXMR6JE1R7S15c7lWOLa0QLGM/t4nkRDd+H74LNeuu ZnJfQrmGvkUGfJvZjldsoJR6iKxxgi7mT7DSNc7M=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9fe399ea7002972d09693a0af60f738e3bdc45b092cf00000001181c0f4992a169ce17019477@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2075/review/180578447@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2075@github.com>
References: <quicwg/base-drafts/pull/2075@github.com>
Subject: Re: [quicwg/base-drafts] Define INITIAL_PRIORITY frame and remove exclusive dependencies (#2075)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c044d49d5db8_1d483fe5de2d45c06341b0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lIxU84Fx9PFn7T8KqYbBBmb6NlI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Dec 2018 21:23:24 -0000

LPardue approved this pull request.

I think the general theme of the PR is good. I've made some minor suggestions. 

The big question is: new frame or rework existing PRIORITY frame. I'll see how that conversation develops.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2075#pullrequestreview-180578447

v2.31.3 | Report a Bug | By Email | System Status