IETF Logo Mail Archive

Re: [quicwg/base-drafts] Track smallest_newly_acked to prevent spurious RTO (#1822)

janaiyengar <notifications@github.com> Wed, 03 October 2018 19:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7650F129385 for <quic-issues@ietfa.amsl.com>; Wed, 3 Oct 2018 12:33:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.455
X-Spam-Level:
X-Spam-Status: No, score=-8.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oLCeQyUskusr for <quic-issues@ietfa.amsl.com>; Wed, 3 Oct 2018 12:33:36 -0700 (PDT)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D52CE1292AD for <quic-issues@ietf.org>; Wed, 3 Oct 2018 12:33:36 -0700 (PDT)
Date: Wed, 03 Oct 2018 12:33:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538595214; bh=O7l0vnRO/jaL0pJ/4OwBlbgzcJwJS74AKTZENAFQILk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=N80ZnvnT7QwRNXG/SoOPlg0FV5U51HDht8gKJZUVyLWobOV+EPLD1bI2m/qNsd8qI gdyoqmWVlKsuiU3yda9LYyaXE3oZmcKlx6CX0nLVnc865QBXuSVqspBZE1txKJ/bH3 24E09sKwS1t5KSqpxOaM+CfKPnPX+zSaCrIso2Uw=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7b015e0369a003750e1c48cb6c1056003b5a76ee92cf0000000117ccdb8e92a169ce15d08f48@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1822/review/161326463@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1822@github.com>
References: <quicwg/base-drafts/pull/1822@github.com>
Subject: Re: [quicwg/base-drafts] Track smallest_newly_acked to prevent spurious RTO (#1822)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb5198e3bd77_6eec3fb437ad45b41660e2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lM1nRvJI43CcAhOnBLunA90szjY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 19:33:38 -0000

janaiyengar commented on this pull request.



>      for acked_packet in DetermineNewlyAckedPackets():
+      smallest_newly_acked =
+        min(smallest_newly_acked, acked_packet.packet_number)

This assumes an ordering in the processing of the acked packets data structure. I would make this simpler:

// Find all newly acked packets in this ACK frame
newly_acked = DetermineNewlyAckedPackets(ack)

// Find the smallest packet that is newly acked in this ACK frame.
smallest_newly_acked = FindSmallestNewlyAcked(newly_acked)

You don't have to define either function, but add a comment that describes what they do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1822#pullrequestreview-161326463

v2.27.8 | Report a Bug | By Email | System Status