Re: [quicwg/base-drafts] Extension frames (#1068)

Dmitri Tikhonov <notifications@github.com> Wed, 04 April 2018 12:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0207912895E for <quic-issues@ietfa.amsl.com>; Wed, 4 Apr 2018 05:28:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zrgtvdanSMS6 for <quic-issues@ietfa.amsl.com>; Wed, 4 Apr 2018 05:28:30 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A8501250B8 for <quic-issues@ietf.org>; Wed, 4 Apr 2018 05:28:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=NyCMvEkMIwLT4Z2j5OwkcyzQDW0=; b=jrieiLx4ZFh21EbF L0U+ml605LXgYUWdQabCnDuAr9jg7YrYeXuum3vFwcg7p+BU1WI2/jXbsd4igZuP ohh7WWTsW43B0USb037QL3UBOS66lg4vjsiJHHIlOXKXEGgrInT9v2cVuM+EN6dm SEU9Rcw+MW1882L3lmlv3iv/yVM=
Received: by filter0077p1las1.sendgrid.net with SMTP id filter0077p1las1-30070-5AC4C4BF-1 2018-04-04 12:27:43.128657617 +0000 UTC
Received: from smtp.github.com (out-1.smtp.github.com [192.30.252.192]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id IGMMG91WRrKcABqLKXXLlA for <quic-issues@ietf.org>; Wed, 04 Apr 2018 12:27:43.006 +0000 (UTC)
Date: Wed, 04 Apr 2018 12:27:43 +0000
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0766532f248991503e78610094e2d898f21c9c2e92cf0000000116dc86be92a169ce115ea54e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1068/review/109302831@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1068@github.com>
References: <quicwg/base-drafts/pull/1068@github.com>
Subject: Re: [quicwg/base-drafts] Extension frames (#1068)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ac4c4bee5d4b_7bf02aeea0508ed09341f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3BxU3FpqDhFG0RhgdMCD5CAg1lDwZkZxCILf 7n64v+uLNoP7VdhJaY7e0ZjaNrq+WDf4Nx1aTmNZpgTs+d5/yLTbnerRDo7AE8Auh1uCd6wQ/j2Ea6 LtIwwx9Vfk8UXJ1hGUG9BhBrARzIt0YSS+B+erMK4601txgD0xYk8piZMkHgc2KF9XOc4BNbqcFPf4 o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lSUJob7V3eQuPU2tZrTqVj0FAPo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 12:28:32 -0000

dtikhonov commented on this pull request.



> +| 0x02        | CONNECTION_CLOSE   | {{frame-connection-close}}  |
+| 0x03        | APPLICATION_CLOSE  | {{frame-application-close}} |
+| 0x04        | MAX_DATA           | {{frame-max-data}}          |
+| 0x05        | MAX_STREAM_DATA    | {{frame-max-stream-data}}   |
+| 0x06        | MAX_STREAM_ID      | {{frame-max-stream-id}}     |
+| 0x07        | PING               | {{frame-ping}}              |
+| 0x08        | BLOCKED            | {{frame-blocked}}           |
+| 0x09        | STREAM_BLOCKED     | {{frame-stream-blocked}}    |
+| 0x0a        | STREAM_ID_BLOCKED  | {{frame-stream-id-blocked}} |
+| 0x0b        | NEW_CONNECTION_ID  | {{frame-new-connection-id}} |
+| 0x0c        | STOP_SENDING       | {{frame-stop-sending}}      |
+| 0x0d        | ACK                | {{frame-ack}}               |
+| 0x0e        | PATH_CHALLENGE     | {{frame-path-challenge}}    |
+| 0x0f        | PATH_RESPONSE      | {{frame-path-response}}     |
+| 0x10 - 0x17 | STREAM             | {{frame-stream}}            |
+| 0x80 - 0xff | (extension frames) | {{frame-extension}}         |

Maybe save `0xFF` for a "super-extension" to allow for more than 128 extended frames?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1068#pullrequestreview-109302831