Re: [quicwg/base-drafts] Describe inputs to TLS more clearly (#4011)

Jana Iyengar <notifications@github.com> Fri, 04 September 2020 20:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1CFD3A102D for <quic-issues@ietfa.amsl.com>; Fri, 4 Sep 2020 13:46:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CAYlLmWNSK4B for <quic-issues@ietfa.amsl.com>; Fri, 4 Sep 2020 13:46:49 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 485743A102B for <quic-issues@ietf.org>; Fri, 4 Sep 2020 13:46:49 -0700 (PDT)
Received: from github-lowworker-1b8c660.ash1-iad.github.net (github-lowworker-1b8c660.ash1-iad.github.net [10.56.18.59]) by smtp.github.com (Postfix) with ESMTP id 2C2A2840D9B for <quic-issues@ietf.org>; Fri, 4 Sep 2020 13:46:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599252408; bh=MH4KKSbJUYGr4T30BW53LAhRes5nFiPYEwGPvXeBm4U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=09PIyV1I4cdToJ79LdwnSBT8CfwlToM645PvyR6EQ/XgN7toyJwELl+R605XzkoKf kIlxXQMNx4jKl7q9f4vCsyZseHYTEa8qmXq6T+xx11eaZnPT+3kZdRRkah1UeWF7Ae czrny2aZ9xeyLHzFWCnKjf9EFpARTnrmzuRbUKic=
Date: Fri, 04 Sep 2020 13:46:48 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2G5X5T2HQSOXPEMBF5L2ELREVBNHHCRENCFU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4011/review/482923644@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4011@github.com>
References: <quicwg/base-drafts/pull/4011@github.com>
Subject: Re: [quicwg/base-drafts] Describe inputs to TLS more clearly (#4011)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f52a7b81d24b_226119f0130295"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lT03wcFnSqqrdwrncpcSnj4FDXA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Sep 2020 20:46:51 -0000

@janaiyengar commented on this pull request.



> -available.  If the keys are generated asynchronously, an endpoint MAY continue
-responding to the received packets that were processable while waiting for TLS
-to provide these keys.
+QUIC that reading or writing keys at that encryption level are available.
+
+The events that cause new keys to be available are not asynchronous; they
+always occur after TLS is provided with inputs. TLS only provides new keys
+after being initialized (by a client) or after being provided with new
+handshake data.
+
+However, a TLS implementation could perform some of its processing
+asynchronously. In particular, the process of validating a certificate can take
+some time. While waiting for TLS processing to complete, an endpoint SHOULD
+buffer received packets if they might be processed using keys that aren't yet
+available. These packets can be processed once keys are provided by TLS. An
+endpoint MAY continue to respond to packets that can be processed during this

This text comes from #3874. @ianswett did [raise this exact point there](https://github.com/quicwg/base-drafts/pull/3874/commits/f851c8c09372918c9b735053084707f24f066547#r468890923), and I argued that it wasn't necessary to make this a SHOULD.

As I look at the text again, I think I was wrong in pushing back then. The intent was to have the receiver buffer and respond, so I think it actually making this a SHOULD expresses that intent better.

> @@ -499,12 +499,23 @@ handshake, new data is requested from TLS after providing received data.
 ### Encryption Level Changes
 
 As keys at a given encryption level become available to TLS, TLS indicates to
-QUIC that reading or writing keys at that encryption level are available.  While
-generating these keys, an endpoint SHOULD buffer received packets marked as
-protected by the keys being generated, and process them once those keys become
-available.  If the keys are generated asynchronously, an endpoint MAY continue
-responding to the received packets that were processable while waiting for TLS
-to provide these keys.
+QUIC that reading or writing keys at that encryption level are available.
+
+The events that cause new keys to be available are not asynchronous; they

I think dropping "asynchronous" from this sentence is fine -- the next para holds up well in describing what asynchronous actually means.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4011#discussion_r483837120