[quicwg/base-drafts] incorrect error code used for invalid RETIRE_CONNECTION_ID frames (#3860)
Marten Seemann <notifications@github.com> Wed, 08 July 2020 05:01 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A37F3A07F9 for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 22:01:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rlbn89CWWKSr for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 22:01:25 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D9F33A07EE for <quic-issues@ietf.org>; Tue, 7 Jul 2020 22:01:25 -0700 (PDT)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net [10.48.25.52]) by smtp.github.com (Postfix) with ESMTP id 9115C8C1713 for <quic-issues@ietf.org>; Tue, 7 Jul 2020 22:01:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594184484; bh=0LB/3tzJh1gFuJskp8yWO1n2ibqvVCVpyxZouzetFag=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=mNUy9s+bPaOz2ic9JTKQSOkQ2yDGEau+nOMCx3PeafHlO/ecQaqfCuUNKNHJbdJy9 ZXsC2QXdZcwbJdAfvzwRhRss2GR7BPuGGrm96Dk03YI2PBtTtDQTNvD7XwYMhpTRyS BlkTWiOgRUMa/WiSSLbbWX4ihXLCEgPHhW0NrGCE=
Date: Tue, 07 Jul 2020 22:01:24 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7CLGZPFD5W4763GPF5CE2CJEVBNHHCN23WDA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3860@github.com>
Subject: [quicwg/base-drafts] incorrect error code used for invalid RETIRE_CONNECTION_ID frames (#3860)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f05532480bcb_48d13f83742cd9688846a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lVFsLGtuB0w6iGtsMfn7kz81u4o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2020 05:01:28 -0000
> The sequence number specified in a RETIRE_CONNECTION_ID frame MUST NOT refer to the Destination Connection ID field of the packet in which the frame is contained. The peer MAY treat this as a connection error of type FRAME_ENCODING_ERROR. Our principle regarding error codes states that only those errors that are detectable without accessing connection state should result in a FRAME_ENCODING_ERROR. Since the RETIRE_CONNECTION_ID frame contains only the sequence number of the connection ID, but not the actual connection ID itself, this should be a different error. Looking through the list of error codes, it seems like we don't have any more specific error code here, so this would be a PROTOCOL_VIOLATION. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/3860
- Re: [quicwg/base-drafts] incorrect error code use… Martin Thomson
- [quicwg/base-drafts] incorrect error code used fo… Marten Seemann
- Re: [quicwg/base-drafts] incorrect error code use… Lucas Pardue
- Re: [quicwg/base-drafts] incorrect error code use… ianswett
- Re: [quicwg/base-drafts] incorrect error code use… Jana Iyengar
- Re: [quicwg/base-drafts] incorrect error code use… Lars Eggert
- Re: [quicwg/base-drafts] incorrect error code use… Martin Thomson
- Re: [quicwg/base-drafts] incorrect error code use… Dmitri Tikhonov