Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167)

Jana Iyengar <notifications@github.com> Wed, 30 October 2019 00:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05D5112008B for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 17:18:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j7a4sbt7AXPx for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 17:17:58 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE63212007A for <quic-issues@ietf.org>; Tue, 29 Oct 2019 17:17:58 -0700 (PDT)
Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id D4F84A0212 for <quic-issues@ietf.org>; Tue, 29 Oct 2019 17:17:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572394677; bh=SJKueeFTroIdgBX/Xpqh47VfIWpkbqoHDFuJpKRV234=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DAMNfmkQjSQegzU4XAezuUZg+QMhCQahHNSDobX6teSUgOTZmdhtDFP6lk1SRSFSg qA3vex+Qat38D2dkBXz5dexds1kAoMEQxRtDdbUCv6anSFR69dvcBBBL4zjPMHboeI gIcGIh5bomWRqWIUKpXVBNdlwhBr83oUYVaZxGbU=
Date: Tue, 29 Oct 2019 17:17:57 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZGQ5JJPAAJX4EY3253YYLULEVBNHHB5JW7PY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3167/review/308906634@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3167@github.com>
References: <quicwg/base-drafts/pull/3167@github.com>
Subject: Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8d6b5c5725_c703f9be88cd96c174351"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lXrXOkb6lns-iAcbFe_hTJxIhbI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2019 00:18:00 -0000

janaiyengar commented on this pull request.

another fix

> @@ -1258,6 +1254,13 @@ kPersistentCongestionThreshold:
 Variables required to implement the congestion control mechanisms
 are described in this section.
 
+max_datagram_size:
+: The sender's current maximum payload size. Does not include UDP or IP
+  overhead.  The max datagram size is used for calculating the minimum

Used for min, init, and cwnd increases, not just for min.
```suggestion
  overhead.  The max datagram size is used for congestion window
```

> @@ -1258,6 +1254,13 @@ kPersistentCongestionThreshold:
 Variables required to implement the congestion control mechanisms
 are described in this section.
 
+max_datagram_size:
+: The sender's current maximum payload size. Does not include UDP or IP
+  overhead.  The max datagram size is used for calculating the minimum
+  congestion window. An endpoint sets the value of this variable based on its

```suggestion
  computations. An endpoint sets the value of this variable based on its
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3167#pullrequestreview-308906634