Re: [quicwg/base-drafts] editorial: simplify pseudo code (recovery) (#3384)

Martin Thomson <notifications@github.com> Wed, 22 January 2020 23:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE0A41201B7 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 15:51:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4SMf9VYyQ1eg for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 15:51:11 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 917961200B8 for <quic-issues@ietf.org>; Wed, 22 Jan 2020 15:51:11 -0800 (PST)
Date: Wed, 22 Jan 2020 15:51:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579737070; bh=M0rDWpbY0Dw62pzi3sSyNN1Fpzc7YdzVROpKcj7N+TA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wIH+2iDQ3TpqI0ffLnr1ITMqTQmxz8qRWir21MXN/U4CUeTmS9O/2FVJwok7Zs9yj M4jYB2muFpdAuI8YtY1Wkk+BT1lNeK9v9YiMaSQ7X0NAw7g0V78fXbcYhDx/0Eyxg4 IITns4LZ5usK2lrfYlP3fBxOcAhOs0Pw0JmTLk5I=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4K23PGPBAHYGUE2MF4GYJG5EVBNHHCCACHAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3384/review/346983496@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3384@github.com>
References: <quicwg/base-drafts/pull/3384@github.com>
Subject: Re: [quicwg/base-drafts] editorial: simplify pseudo code (recovery) (#3384)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e28dfeeb7975_76bc3fd6cd8cd9602364f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ljUSktKIkui7fq6HLn2Wm4guFL4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 23:51:13 -0000

martinthomson commented on this pull request.



> @@ -346,9 +346,7 @@ On subsequent RTT samples, smoothed_rtt and rttvar evolve as follows:
 
 ~~~
 ack_delay = min(Ack Delay in ACK Frame, max_ack_delay)
-adjusted_rtt = latest_rtt
-if (min_rtt + ack_delay < latest_rtt):
-  adjusted_rtt = latest_rtt - ack_delay
+adjusted_rtt = max(latest_rtt - ack_delay, min_rtt)

Right, this is a functional change.

Prior to this you get `latest_rtt` or `latest_rtt - ack_delay`.

With this change you get `min_rtt` or `latest_rtt - ack_delay`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3384#discussion_r369868333