Date: Wed, 22 Jan 2020 15:51:10 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK4K23PGPBAHYGUE2MF4GYJG5EVBNHHCCACHAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3384/review/346983496@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3384@github.com>
References: <quicwg/base-drafts/pull/3384@github.com>
Subject: Re: [quicwg/base-drafts] editorial: simplify pseudo code (recovery)
 (#3384)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e28dfeeb7975_76bc3fd6cd8cd9602364f";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ljUSktKIkui7fq6HLn2Wm4guFL4>


----==_mimepart_5e28dfeeb7975_76bc3fd6cd8cd9602364f
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson commented on this pull request.



> @@ -346,9 +346,7 @@ On subsequent RTT samples, smoothed_rtt and rttvar evolve as follows:
 
 ~~~
 ack_delay = min(Ack Delay in ACK Frame, max_ack_delay)
-adjusted_rtt = latest_rtt
-if (min_rtt + ack_delay < latest_rtt):
-  adjusted_rtt = latest_rtt - ack_delay
+adjusted_rtt = max(latest_rtt - ack_delay, min_rtt)

Right, this is a functional change.

Prior to this you get `latest_rtt` or `latest_rtt - ack_delay`.

With this change you get `min_rtt` or `latest_rtt - ack_delay`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3384#discussion_r369868333
----==_mimepart_5e28dfeeb7975_76bc3fd6cd8cd9602364f
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3384#discussion_r369868333">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -346,9 +346,7 @@ On subsequent RTT samples, smoothed_rtt and rttvar evolve as follows:
 
 ~~~
 ack_delay = min(Ack Delay in ACK Frame, max_ack_delay)
-adjusted_rtt = latest_rtt
-if (min_rtt + ack_delay &lt; latest_rtt):
-  adjusted_rtt = latest_rtt - ack_delay
+adjusted_rtt = max(latest_rtt - ack_delay, min_rtt)
</pre>
<p>Right, this is a functional change.</p>
<p>Prior to this you get <code>latest_rtt</code> or <code>latest_rtt - ack_delay</code>.</p>
<p>With this change you get <code>min_rtt</code> or <code>latest_rtt - ack_delay</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3384?email_source=notifications&amp;email_token=AFTOJK6E2VSFWDBD7R7SX6TQ7DLW5A5CNFSM4KKJA5ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSXIYSA#discussion_r369868333">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK4QB7VKBG4ZTQGB72DQ7DLW5ANCNFSM4KKJA5ZA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZIFSRM3S4E44UPMLTQ7DLW5A5CNFSM4KKJA5ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSXIYSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3384?email_source=notifications\u0026email_token=AFTOJK6E2VSFWDBD7R7SX6TQ7DLW5A5CNFSM4KKJA5ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSXIYSA#discussion_r369868333",
"url": "https://github.com/quicwg/base-drafts/pull/3384?email_source=notifications\u0026email_token=AFTOJK6E2VSFWDBD7R7SX6TQ7DLW5A5CNFSM4KKJA5ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSXIYSA#discussion_r369868333",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e28dfeeb7975_76bc3fd6cd8cd9602364f--