Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 1A361126F72
 for <quic-issues@ietfa.amsl.com>; Tue, 30 Oct 2018 20:48:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level: 
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001,
 MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id LHM1w2vpeOkC for <quic-issues@ietfa.amsl.com>;
 Tue, 30 Oct 2018 20:48:03 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 9CF2B1252B7
 for <quic-issues@ietf.org>; Tue, 30 Oct 2018 20:48:03 -0700 (PDT)
Date: Tue, 30 Oct 2018 20:48:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1540957682;
 bh=w6kS02f0SySc5wH2n5Anqe2SrIiOXuCp3EIWT4U01yU=;
 h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post:
 List-Unsubscribe:From;
 b=Q86KRKRqo8pXHmzaJDkQRwvDnvpS6sOEwDJ4sDneyc4Lqr8JCU8DQVs5mIMHhq97v
 GnWskRHYVDmsdfufc4Tdl49VOlnEyePMPNBe2vGp6b0AjkHlQSoVu10ZOlgJCQMDg1
 8MnV7Vu5utIFl39JwWxkW0kEDHJcl6X54gvc1c2Y=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab386fb872e0e2b43596447a2564cad8ddf480325892cf0000000117f0e7f292a169ce16660d11@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1940@github.com>
Subject: [quicwg/base-drafts] Why are error codes not a varint? (#1940)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5bd925f2e40c1_32153fe3726d45bc61846f";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lqpaTIfbozFqZuXMNzgboHe4-XM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2018 03:48:05 -0000


----==_mimepart_5bd925f2e40c1_32153fe3726d45bc61846f
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

The error codes in CONNECTION_CLOSE and RST_STREAM frames are uint16s. That's inconsistent with how we encode pretty much every other value.

While saving bytes is not the reason I'm opening this issue, depending on how frequently streams are reset, it might be nice to save a byte on the error code as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1940
----==_mimepart_5bd925f2e40c1_32153fe3726d45bc61846f
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>The error codes in CONNECTION_CLOSE and RST_STREAM frames are uint16s. That's inconsistent with how we encode pretty much every other value.</p>
<p>While saving bytes is not the reason I'm opening this issue, depending on how frequently streams are reset, it might be nice to save a byte on the error code as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/issues/1940">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq6dQ01IX_1OkV9Woeacc6vIGbTDvks5uqR1ygaJpZM4YDS68">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkqx18kOi0AdcjobgBzLNeJAj1kjY3ks5uqR1ygaJpZM4YDS68.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Why are error codes not a varint? (#1940)"}],"action":{"name":"View Issue","url":"https://github.com/quicwg/base-drafts/issues/1940"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/1940",
"url": "https://github.com/quicwg/base-drafts/issues/1940",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Why are error codes not a varint? (#1940)",
"sections": [
{
"text": "",
"activityTitle": "**Marten Seemann**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@marten-seemann",
"facts": [
{
"name": "Repository: ",
"value": "quicwg/base-drafts"
},
{
"name": "Issue #: ",
"value": 1940
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"quicwg/base-drafts\",\n\"issueId\": 1940,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"quicwg/base-drafts\",\n\"issueId\": 1940\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/issues/1940"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 403517116\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5bd925f2e40c1_32153fe3726d45bc61846f--