Re: [quicwg/base-drafts] Gorry's ECN rewrite (#4059)

Gorry Fairhurst <notifications@github.com> Thu, 10 September 2020 07:31 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7D773A0FA1 for <quic-issues@ietfa.amsl.com>; Thu, 10 Sep 2020 00:31:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TUmlYQggSe1h for <quic-issues@ietfa.amsl.com>; Thu, 10 Sep 2020 00:31:04 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DC8233A0F9E for <quic-issues@ietf.org>; Thu, 10 Sep 2020 00:31:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=oleg4NorvHR4+alhfGHTuZj5o301raDuWo8piR6je7c=; b= srgx+uIncuhmBoeu1gLpIoGPWeusckX4ksJjfVJSdZKdnXGsRhh9c9NRKdlUA4HZ vnrhIUYpVRZR3yzIe7jbDC94mb149beOlyRTSl+h6FpRNY57N4gkVKmYWPv8r7tr A99AB22mZcSvlr4AlNRqMD/vBRntV8+n8WwZ4+/7w0A=
Received: by filter0730p1iad2.sendgrid.net with SMTP id filter0730p1iad2-19314-5F59D636-2F 2020-09-10 07:31:02.915745676 +0000 UTC m=+484931.293949185
Received: from github-lowworker-1b8c660.ash1-iad.github.net (unknown) by geopod-ismtpd-2-1 (SG) with ESMTP id a34WqbKgTiir0y94xL3tcQ for <quic-issues@ietf.org>; Thu, 10 Sep 2020 07:31:02.899 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1b8c660.ash1-iad.github.net (Postfix) with ESMTP id BD75C4E0589 for <quic-issues@ietf.org>; Thu, 10 Sep 2020 00:31:02 -0700 (PDT)
Date: Thu, 10 Sep 2020 07:31:02 +0000
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6BSQIXYMA2NHO5OLF5MW3TNEVBNHHCR5CFZA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4059/review/485654380@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4059@github.com>
References: <quicwg/base-drafts/pull/4059@github.com>
Subject: Re: [quicwg/base-drafts] Gorry's ECN rewrite (#4059)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f59d636bb8dd_26f919f04728f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1LbFaCw3bJP4kXyq9Xk14qvz3OvoTbXA3F5E ZbfqzI55OJ6y7WjO6wmptIgjr2OLgMk0pIG2hjBqx5bvKQqH5dxQjP+0jOyk8pbQmB9RAxLR0F6R0L tcBezE1TDl4kJ/ApI8CT2IHgFXYilxujy1AazMkg8rxRRfxbenTJIo8OPYxRY0J/9YE7k837TiBbk6 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lsIIPOVCRlA4lzSsVKJmLFr9B6E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Sep 2020 07:31:08 -0000

@gorryfair commented on this pull request.



>  
 
 ### ECN Counts
 
-On receiving a QUIC packet with an ECT or CE codepoint, an ECN-enabled endpoint
-that can access the ECN codepoints from the enclosing IP packet increases the
-corresponding ECT(0), ECT(1), or CE count, and includes these counts in
-subsequent ACK frames; see {{generating-acks}} and {{frame-ack}}.
-
-An IP packet that results in no QUIC packets being processed does not increase
-ECN counts.  A QUIC packet detected by a receiver as a duplicate does not
-affect the receiver's local ECN codepoint counts; see {{security-ecn}} for
-relevant security concerns.
+Use of ECN requires the receiving endpoint to read the ECN codepoint from an IP

Can I suggest: /To enable the congestion controller to react to CE-marked packets, the sender needs to be able to set an ECT codepoint in the IP header and the receiver needs to be able to read the ECN field from an IP packet./
...i.e.,  removing /in order/ ... /ECN code point/ is the /ECN-field/ or name the code point value(s).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4059#discussion_r486124740