Re: [quicwg/base-drafts] Use the same KDF regardless of TLS version (#2034)

janaiyengar <notifications@github.com> Wed, 21 November 2018 23:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43214128D0C for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 15:47:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aiRavWGA7id3 for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 15:47:33 -0800 (PST)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF6B0128CF3 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 15:47:33 -0800 (PST)
Date: Wed, 21 Nov 2018 15:47:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542844053; bh=2EoyokVOgRvcMSdAlquLF9oW31dziiu5X7BawVqGEP8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=IUpWYvHWFEHWlb3k8mgkS8iMPusdgMSEVXMQrvIY50C6n1roFXPtvhv5ntMAYYOm2 htM6ayZ7/oJ6emKyqFr4My+4IWXhghzbjcNYfO1OOP4IMbfOU4KBumVqrrUDEuW2aF P1Jm6/jZXD6Jgy1ht/AgRl2J7hpmcHEyUhyfD2rY=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4c15d7e39dfbb8c29bd29981fb4e90eda0c5e7cf92cf00000001180db09492a169ce16d3c410@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2034/review/177464395@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2034@github.com>
References: <quicwg/base-drafts/pull/2034@github.com>
Subject: Re: [quicwg/base-drafts] Use the same KDF regardless of TLS version (#2034)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf5ee94e7385_66c43fe6ee2d45b4233956"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lsm0DkbTpC4gh_-UxmSbuH52eWM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 23:47:36 -0000

janaiyengar commented on this pull request.



> @@ -715,6 +715,11 @@ method described in Section 7.3 of {{!TLS13}}), with the labels "quic key" and
 respectively).  Using these labels provides key separation between QUIC and TLS,
 see {{key-diversity}}.
 
+The HKDF-Expand-Label function defined in TLS 1.3 MUST be used even when a
+different TLS version is negotiated, or - for Initial packets - if the TLS
+versions offered do not include TLS 1.3.  This ensures that the selection of TLS
+version is independent of the process used to derive QUIC keys.

It might be useful to describe the nuance here  -- that Initial packets are expected to be decrypted before a TLS version is negotiated, and therefore there needs to be prior agreement on the HKDF-Expand-Label function used for it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2034#pullrequestreview-177464395