IETF Logo Mail Archive

Re: [quicwg/base-drafts] RFC Editor Copyedits (PR #4956)

Mike Bishop <notifications@github.com> Tue, 15 February 2022 20:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB6BD3A043F for <quic-issues@ietfa.amsl.com>; Tue, 15 Feb 2022 12:51:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.665
X-Spam-Level:
X-Spam-Status: No, score=-8.665 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.576, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3iSY15TVgvD6 for <quic-issues@ietfa.amsl.com>; Tue, 15 Feb 2022 12:51:30 -0800 (PST)
Received: from smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 123593A040A for <quic-issues@ietf.org>; Tue, 15 Feb 2022 12:51:29 -0800 (PST)
Received: from github-lowworker-b19c547.va3-iad.github.net (github-lowworker-b19c547.va3-iad.github.net [10.48.17.66]) by smtp.github.com (Postfix) with ESMTP id 262F15C08CF for <quic-issues@ietf.org>; Tue, 15 Feb 2022 12:51:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1644958289; bh=CXwAgMgVyACQAXA+CuwqJ7TAJFelYo6oW8Li0EN8DFw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=q/zruDTJa9vP+l+Bmd4RIRP3egdOQzX2kSenJOtavP7O1X11RCeDYVUsf1c22fOWS zjvSchEZcf0hVCVmTqWpA1uStGTAu390j+Iu3dEWVQdpaTetAJD2Czv4bx+HRREYbY 42+KojYyRu1WsCgNPZQ6QpTZef/7UFyQt0bCIEjg=
Date: Tue, 15 Feb 2022 12:51:29 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZKMOJQXX6TEPBHSIWAC7ZVDEVBNHHEHZVETM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4956/review/883634596@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4956@github.com>
References: <quicwg/base-drafts/pull/4956@github.com>
Subject: Re: [quicwg/base-drafts] RFC Editor Copyedits (PR #4956)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_620c125118eef_71c6c6fc3085682"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ltLx8MnlHrmMFNgNMLy-Miio61A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Feb 2022 20:51:32 -0000

@MikeBishop commented on this pull request.



>  implementation can decide to close a QUIC stream and communicate the type of
 error. Wire encodings of error codes are defined in {{http-error-codes}}.
-Stream errors are distinct from HTTP status codes which indicate error
+Stream errors are distinct from HTTP status codes that indicate error

The RFC editor proposed adding a comma, producing
```suggestion
Stream errors are distinct from HTTP status codes, which indicate error
```
However, that suggests that _all_ HTTP status codes indicate error conditions.  Instead, I've changed which->that indicating that here we're discussing only those HTTP status codes that indicate an error.

Along the way, I've had to learn the difference between the usage of "which" and "that", which still trips me up.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4956#pullrequestreview-883634596
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4956/review/883634596@github.com>

v2.8.7 | Report a Bug | By Email