Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)

[Martin Thomson <[e-mail]>]

@martinthomson commented on this pull request.

Yeah, this is much clearer.

>        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)
+  # Arm PTO from now when there are no inflight packets
+  if (no in-flight packets):
+    return now() + duration, Initial

```suggestion
    return (now() + duration), Initial
```

> +    if (timeout >
+          time_of_last_ack_eliciting_packet[space] + duration):
+      timeout =
+          time_of_last_ack_eliciting_packet[space] + duration

```suggestion
    t = time_of_last_ack_eliciting_packet[space] + duration
    if (t < timeout):
      timeout = t
```

>        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)
+  # Arm PTO from now when there are no inflight packets
+  if (no in-flight packets):
+    return now() + duration, Initial
+  timeout = infinite
+  pn_space = Initial

using space and pn_space is awkward, how about naming this pto_space (and maybe then pto_time for timeout)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-415799805