Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F1C73A0415 for ; Wed, 20 May 2020 17:23:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -3.1 X-Spam-Level: X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CkN0U_gllAsv for ; Wed, 20 May 2020 17:23:57 -0700 (PDT) Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CD6983A0414 for ; Wed, 20 May 2020 17:23:57 -0700 (PDT) Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id 26B8112139C for ; Wed, 20 May 2020 17:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590020637; bh=INpEO6Ph6yNBKgKem6SXYjU0Q7TsJKDm2NoA2awB+R8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YzMHTITK8Luh7sWdvEaiaiVtbpZbkivV8HioNvlctpMnUySusJB/AcGtiqtbynyrv IMn7QiMjtafN5hdg7EMiHHIL9xCuRkc1KJ9kYwHbXZtzzadBYo333HvRQOnnkWB3+h 51zAFo3XEIfceddZPm93i9BdjO3aLHhk6kxOAZzI= Date: Wed, 20 May 2020 17:23:56 -0700 From: Martin Thomson Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5ec5ca1cd4193_2af83fecc68cd96015054f"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: martinthomson X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 00:24:00 -0000 ----==_mimepart_5ec5ca1cd4193_2af83fecc68cd96015054f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @martinthomson commented on this pull request. Yeah, this is much clearer. > space = pn_space return time, space +GetPtoTimeAndSpace(): + duration = smoothed_rtt + + max(4 * rttvar, kGranularity) * (2 ^ pto_count) + # Arm PTO from now when there are no inflight packets + if (no in-flight packets): + return now() + duration, Initial ```suggestion return (now() + duration), Initial ``` > + if (timeout > + time_of_last_ack_eliciting_packet[space] + duration): + timeout = + time_of_last_ack_eliciting_packet[space] + duration ```suggestion t = time_of_last_ack_eliciting_packet[space] + duration if (t < timeout): timeout = t ``` > space = pn_space return time, space +GetPtoTimeAndSpace(): + duration = smoothed_rtt + + max(4 * rttvar, kGranularity) * (2 ^ pto_count) + # Arm PTO from now when there are no inflight packets + if (no in-flight packets): + return now() + duration, Initial + timeout = infinite + pn_space = Initial using space and pn_space is awkward, how about naming this pto_space (and maybe then pto_time for timeout) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-415799805 ----==_mimepart_5ec5ca1cd4193_2af83fecc68cd96015054f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

=0D

@martinthomson commented on this pull request.

=0D =0D

Yeah, this is much clearer.

=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
>        space =3D pn_space=0D
   return time, space=0D
 =0D
+GetPtoTimeAndSpace():=0D
+  duration =3D smoothed_rtt +=0D
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)=0D
+  # Arm PTO from now when there are no inflight packets=0D
+  if (no in-flight packets):=0D
+    return now() + duration, Initial=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-    return now() + duration, Initial=0D
+    return (now() + duration), Initial=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
> +    if (timeout >=0D
+          time_of_last_ack_eliciting_packet[space] + duration):=0D
+      timeout =3D=0D
+          time_of_last_ack_eliciting_packet[space] + duration=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-    if (timeout >=0D
-          time_of_last_ack_eliciting_packet[space] + duration):=0D
-      timeout =3D=0D
-          time_of_last_ack_eliciting_packet[space] + duration=0D
+    t =3D time_of_last_ack_eliciting_packet[space] + duration=0D
+    if (t < timeout):=0D
+      timeout =3D t=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
>        space =3D pn_space=0D
   return time, space=0D
 =0D
+GetPtoTimeAndSpace():=0D
+  duration =3D smoothed_rtt +=0D
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)=0D
+  # Arm PTO from now when there are no inflight packets=0D
+  if (no in-flight packets):=0D
+    return now() + duration, Initial=0D
+  timeout =3D infinite=0D
+  pn_space =3D Initial=0D
=0D

using space and pn_space is awkward, how about naming this pto_space (= and maybe then pto_time for timeout)

=0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or unsubscribe.3D""

=0D = ----==_mimepart_5ec5ca1cd4193_2af83fecc68cd96015054f--