Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

ianswett <notifications@github.com> Thu, 10 October 2019 16:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2D43120233 for <quic-issues@ietfa.amsl.com>; Thu, 10 Oct 2019 09:40:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eTmctK8eNSxp for <quic-issues@ietfa.amsl.com>; Thu, 10 Oct 2019 09:40:10 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C40E11200F6 for <quic-issues@ietf.org>; Thu, 10 Oct 2019 09:40:09 -0700 (PDT)
Date: Thu, 10 Oct 2019 09:40:08 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570725608; bh=cydBlVsMVHThuidC1DDMilsLRCVTePaXD1B3T75OliQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oI78EJ3sItQeiniCJbB95Ao35VkWunHQzF2xMxbOsPw6l9s/p2dttdwNM3ZEBp+Sj AuBce416bjP9D0vm4R8DwrpWItw7SuEWedaFqo+HvjmlwgjYaPk5pv/2p02O0Fe38H BJ38NN7VdFtxaPe0zpaZyeaJkZgA1PFOEvMkMGKo=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ732ADCV6JXEHFEMF3VSPXREVBNHHB4DMTGA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3083/review/300204866@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3083@github.com>
References: <quicwg/base-drafts/pull/3083@github.com>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9f5ee8cfd37_733a3f83500cd95c455d8"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/m-xJmeHxqdDtqQUWa9HcB_O-XRo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Oct 2019 16:40:12 -0000

ianswett commented on this pull request.



> @@ -1071,7 +1071,8 @@ When a server receives this frame, it aborts sending the response for the
 identified server push.  If the server has not yet started to send the server
 push, it can use the receipt of a CANCEL_PUSH frame to avoid opening a push
 stream.  If the push stream has been opened by the server, the server SHOULD

"has been opened" is now a bit odd without any qualification, since it's possible it's been opened and subsequently closed.

How about "If the push stream is open, the server SHOULD abruptly terminate that stream."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3083#pullrequestreview-300204866